From: kernel test robot <lkp@intel.com>
To: Jakub Kicinski <kuba@kernel.org>, davem@davemloft.net
Cc: oe-kbuild-all@lists.linux.dev, netdev@vger.kernel.org,
edumazet@google.com, pabeni@redhat.com, jiri@resnulli.us,
johannes@sipsolutions.net, Jakub Kicinski <kuba@kernel.org>,
Miquel Raynal <miquel.raynal@bootlin.com>,
Jiri Pirko <jiri@nvidia.com>,
Jason@zx2c4.com, alex.aring@gmail.com, stefan@datenfreihafen.org,
krzysztof.kozlowski@linaro.org, jmaloy@redhat.com,
ying.xue@windriver.com, floridsleeves@gmail.com, leon@kernel.org,
jacob.e.keller@intel.com, wireguard@lists.zx2c4.com,
linux-wpan@vger.kernel.org,
tipc-discussion@lists.sourceforge.net
Subject: Re: [PATCH net-next v3 05/10] genetlink: use attrs from struct genl_info
Date: Wed, 16 Aug 2023 05:46:49 +0800 [thread overview]
Message-ID: <202308160545.9cpmjvz9-lkp@intel.com> (raw)
In-Reply-To: <20230814214723.2924989-6-kuba@kernel.org>
Hi Jakub,
kernel test robot noticed the following build errors:
[auto build test ERROR on net-next/main]
url: https://github.com/intel-lab-lkp/linux/commits/Jakub-Kicinski/genetlink-push-conditional-locking-into-dumpit-done/20230815-055212
base: net-next/main
patch link: https://lore.kernel.org/r/20230814214723.2924989-6-kuba%40kernel.org
patch subject: [PATCH net-next v3 05/10] genetlink: use attrs from struct genl_info
config: i386-debian-10.3 (https://download.01.org/0day-ci/archive/20230816/202308160545.9cpmjvz9-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce: (https://download.01.org/0day-ci/archive/20230816/202308160545.9cpmjvz9-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202308160545.9cpmjvz9-lkp@intel.com/
All errors (new ones prefixed by >>):
net/devlink/netlink.c: In function 'devlink_nl_dumpit':
>> net/devlink/netlink.c:232:37: error: 'const struct genl_dumpit_info' has no member named 'attrs'
232 | struct nlattr **attrs = info->attrs;
| ^~
--
net/devlink/health.c: In function 'devlink_nl_health_reporter_get_dump_one':
>> net/devlink/health.c:396:37: error: 'const struct genl_dumpit_info' has no member named 'attrs'
396 | struct nlattr **attrs = info->attrs;
| ^~
vim +232 net/devlink/netlink.c
07f3af66089e20 Jakub Kicinski 2023-01-04 227
4a1b5aa8b5c743 Jiri Pirko 2023-08-11 228 int devlink_nl_dumpit(struct sk_buff *msg, struct netlink_callback *cb,
4a1b5aa8b5c743 Jiri Pirko 2023-08-11 229 devlink_nl_dump_one_func_t *dump_one)
4a1b5aa8b5c743 Jiri Pirko 2023-08-11 230 {
4a1b5aa8b5c743 Jiri Pirko 2023-08-11 231 const struct genl_dumpit_info *info = genl_dumpit_info(cb);
4a1b5aa8b5c743 Jiri Pirko 2023-08-11 @232 struct nlattr **attrs = info->attrs;
4a1b5aa8b5c743 Jiri Pirko 2023-08-11 233 int flags = NLM_F_MULTI;
4a1b5aa8b5c743 Jiri Pirko 2023-08-11 234
4a1b5aa8b5c743 Jiri Pirko 2023-08-11 235 if (attrs &&
4a1b5aa8b5c743 Jiri Pirko 2023-08-11 236 (attrs[DEVLINK_ATTR_BUS_NAME] || attrs[DEVLINK_ATTR_DEV_NAME]))
4a1b5aa8b5c743 Jiri Pirko 2023-08-11 237 return devlink_nl_inst_single_dumpit(msg, cb, flags, dump_one,
4a1b5aa8b5c743 Jiri Pirko 2023-08-11 238 attrs);
4a1b5aa8b5c743 Jiri Pirko 2023-08-11 239 else
4a1b5aa8b5c743 Jiri Pirko 2023-08-11 240 return devlink_nl_inst_iter_dumpit(msg, cb, flags, dump_one);
4a1b5aa8b5c743 Jiri Pirko 2023-08-11 241 }
4a1b5aa8b5c743 Jiri Pirko 2023-08-11 242
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
prev parent reply other threads:[~2023-08-15 21:48 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20230814214723.2924989-1-kuba@kernel.org>
2023-08-14 21:47 ` Jakub Kicinski
2023-08-15 21:46 ` kernel test robot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202308160545.9cpmjvz9-lkp@intel.com \
--to=lkp@intel.com \
--cc=Jason@zx2c4.com \
--cc=alex.aring@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=floridsleeves@gmail.com \
--cc=jacob.e.keller@intel.com \
--cc=jiri@nvidia.com \
--cc=jiri@resnulli.us \
--cc=jmaloy@redhat.com \
--cc=johannes@sipsolutions.net \
--cc=krzysztof.kozlowski@linaro.org \
--cc=kuba@kernel.org \
--cc=leon@kernel.org \
--cc=linux-wpan@vger.kernel.org \
--cc=miquel.raynal@bootlin.com \
--cc=netdev@vger.kernel.org \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=pabeni@redhat.com \
--cc=stefan@datenfreihafen.org \
--cc=tipc-discussion@lists.sourceforge.net \
--cc=wireguard@lists.zx2c4.com \
--cc=ying.xue@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).