From: "Daniel Gröber" <dxld@darkboxed.org>
To: "Jason A. Donenfeld" <Jason@zx2c4.com>
Cc: "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
wireguard@lists.zx2c4.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] wireguard: Fix leaking sockets in wg_socket_init error paths
Date: Mon, 23 Oct 2023 17:59:50 +0200 [thread overview]
Message-ID: <20231023155950.oyl2olisob6dnvwo@House.clients.dxld.at> (raw)
In-Reply-To: <ZTZ9XfPOXD4JXdjk@zx2c4.com>
Hi Jason,
On Mon, Oct 23, 2023 at 04:04:13PM +0200, Jason A. Donenfeld wrote:
> The signed-off-by is missing and the subject does not match the format
> of any other wireguard commits.
Ah, I don't usually send kernel patches. Forgot to do format.signOff=true.
> On Mon, Oct 23, 2023 at 03:06:09PM +0200, Daniel Gröber wrote:
> > This doesn't seem to be reachable normally, but while working on a patch
>
> "Normally" as in what? At all? Or?
I committed this while working on my address/ifindex binding patch[1]
(which I will also resend shortly), at the time I thought this fix makes
sense in isolation but apparently not.
[1]: https://lists.zx2c4.com/pipermail/wireguard/2023-August/008148.html,
> > for the address binding code I ended up triggering this leak and had to
> > reboot to get rid of the leaking wg sockets.
>
> This commit message doesn't describe any rationale for this patch. Can
> you describe the bug?
It's been a while since I wrote this patch. Unfortunately you didn't
respond to my initial mail in Aug, so some context has already been lost to
time.
I may have been under the mistaken impression that udp_sock_create can
return <0 while leaving *sockp!=NULL, but as I recall it I did re-test with
this patch and it fixed the bug, that I wish I remembered how to trigger
now. Unsatisfying.
--Daniel
next prev parent reply other threads:[~2023-10-23 16:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-23 13:06 Daniel Gröber
2023-10-23 14:04 ` Jason A. Donenfeld
2023-10-23 15:59 ` Daniel Gröber [this message]
-- strict thread matches above, loose matches on Subject: below --
2023-08-17 20:02 Daniel Gröber
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231023155950.oyl2olisob6dnvwo@House.clients.dxld.at \
--to=dxld@darkboxed.org \
--cc=Jason@zx2c4.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=wireguard@lists.zx2c4.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).