From: "Daniel Gröber" <dxld@darkboxed.org>
To: Raphael Catolino <rca@koalox.com>, Linus Karl <linus@lotz.li>
Cc: wireguard@lists.zx2c4.com
Subject: Re: [PATCH 1/1] wireguard-linux: add netlink multicast group for notifications on peer change
Date: Wed, 20 Dec 2023 16:04:19 +0100 [thread overview]
Message-ID: <20231220150419.zmtlrv3nhkvx2ymh@House.clients.dxld.at> (raw)
In-Reply-To: <2328185.xqv9EDfTUt@desktop>
Hi Raphael, Linus,
Interesting patch, I've been meaning to get around to adding some change
notifications as well :)
I have some notes:
- It seem to me some more sharing with existing code constructing nlmsgs
ought to be possible your new code seems quite verbose.
- Why is the endpoint_monitor flag necessary? Other genlmsg_multicast
callers don't seem to do anything like this.
Do you have corresponding wireguard-tools userspace patches for this yet?
--Daniel
PS: If you intend for this to get applied you may want to fix
scripts/checkpatch.pl warnings and add people get_maintainers.pl spits out
to Cc.
prev parent reply other threads:[~2023-12-20 15:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-03 19:24 Raphael Catolino
2023-12-20 15:04 ` Daniel Gröber [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231220150419.zmtlrv3nhkvx2ymh@House.clients.dxld.at \
--to=dxld@darkboxed.org \
--cc=linus@lotz.li \
--cc=rca@koalox.com \
--cc=wireguard@lists.zx2c4.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).