From: Jakub Kicinski <kuba@kernel.org>
To: "Asbjørn Sloth Tønnesen" <ast@fiberby.net>
Cc: "Jason A. Donenfeld" <Jason@zx2c4.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
Donald Hunter <donald.hunter@gmail.com>,
Simon Horman <horms@kernel.org>,
Jacob Keller <jacob.e.keller@intel.com>,
Sabrina Dubroca <sd@queasysnail.net>,
wireguard@lists.zx2c4.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v3 06/13] tools: ynl-gen: deduplicate fixed_header handling
Date: Fri, 12 Sep 2025 17:24:18 -0700 [thread overview]
Message-ID: <20250912172418.1271771d@kernel.org> (raw)
In-Reply-To: <20250911200508.79341-7-ast@fiberby.net>
On Thu, 11 Sep 2025 20:04:59 +0000 Asbjørn Sloth Tønnesen wrote:
> Fixed headers are handled nearly identical in print_dump(),
> print_req() and put_req_nested(), generalize them and use a
> common function to generate them.
>
> This only causes cosmetic changes to tc_netem_attrs_put() in
> tc-user.c.
>
> Signed-off-by: Asbjørn Sloth Tønnesen <ast@fiberby.net>
> ---
> tools/net/ynl/pyynl/ynl_gen_c.py | 39 ++++++++++++++++----------------
> 1 file changed, 20 insertions(+), 19 deletions(-)
This only makes the code longer and harder to follow.
next prev parent reply other threads:[~2025-09-13 0:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20250911200508.79341-1-ast@fiberby.net>
[not found] ` <20250911200508.79341-5-ast@fiberby.net>
2025-09-13 0:19 ` [PATCH net-next v3 04/13] tools: ynl-gen: refactor local vars for .attr_put() callers Jakub Kicinski
[not found] ` <20250911200508.79341-6-ast@fiberby.net>
2025-09-13 0:21 ` [PATCH net-next v3 05/13] tools: ynl-gen: add CodeWriter.p_lines() helper Jakub Kicinski
[not found] ` <20250911200508.79341-7-ast@fiberby.net>
2025-09-13 0:24 ` Jakub Kicinski [this message]
[not found] ` <20250911200508.79341-9-ast@fiberby.net>
2025-09-13 0:27 ` [PATCH net-next v3 08/13] tools: ynl-gen: only validate nested array payload Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250912172418.1271771d@kernel.org \
--to=kuba@kernel.org \
--cc=Jason@zx2c4.com \
--cc=ast@fiberby.net \
--cc=davem@davemloft.net \
--cc=donald.hunter@gmail.com \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=jacob.e.keller@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sd@queasysnail.net \
--cc=wireguard@lists.zx2c4.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).