* Re: [PATCH net-next v4 04/11] tools: ynl-gen: refactor local vars for .attr_put() callers
[not found] ` <20250913235847.358851-5-ast@fiberby.net>
@ 2025-09-14 18:08 ` Jakub Kicinski
0 siblings, 0 replies; only message in thread
From: Jakub Kicinski @ 2025-09-14 18:08 UTC (permalink / raw)
To: Asbjørn Sloth Tønnesen
Cc: Jason A. Donenfeld, David S. Miller, Eric Dumazet, Paolo Abeni,
Donald Hunter, Simon Horman, Jacob Keller, Sabrina Dubroca,
wireguard, netdev, linux-kernel
On Sat, 13 Sep 2025 23:58:25 +0000 Asbjørn Sloth Tønnesen wrote:
> Refactor the generation of local variables needed when building
> requests, by moving the logic into the Type classes, and use the
> same helper in all places where .attr_put() is called.
>
> If any attributes requests identical local_vars, then they will
> be deduplicated, attributes are assumed to only use their local
> variables transiently.
Nope, this is not good enough. I prefer the obvious hack than a one-off
member mixed into the object model.
^ permalink raw reply [flat|nested] only message in thread