Development discussion of WireGuard
 help / color / mirror / Atom feed
From: lazerl0rd@thezest.dev
To: "Jason A. Donenfeld" <Jason@zx2c4.com>
Cc: Bruno UT1 <bandry@ut1.org>,
	WireGuard mailing list <wireguard@lists.zx2c4.com>
Subject: Re: [Windows Client] Out of date Title scare my users
Date: Fri, 26 Nov 2021 09:17:38 +0000	[thread overview]
Message-ID: <2b0136d9581406195d542696db53d8cd@purelymail.com> (raw)
In-Reply-To: <CAHmME9rwFyJ4W3nnbTWq0e0X_P_FOQx6Z3kcuUhcYuYjkc0atQ@mail.gmail.com>

I assume you've chosen the "reword" route instead of any larger changes, 
for the better or worse (though as Bruno said, it would be great if 5) 
is considered somewhere down the line).

Since this route was chosen, I suggest that we also reword the update 
prompt itself as I feel that is equally responsible for users "freaking 
out". After all, it is literally telling users to contact their sysadmin 
instantly for each update. I propose something along the lines of the 
following patch (though I guess il8n will be a bit of a pain):

```
 From 76ea8a81cf327527089bfea8209bf4f2faa1b6cf Mon Sep 17 00:00:00 2001
 From: Diab Neiroukh <lazerl0rd@thezest.dev>
Date: Fri, 26 Nov 2021 09:12:15 +0000
Subject: [PATCH] ui: Don't explicitly tell users to contact their 
sysadmin for
  updates.

The wording used here practically told users to instantly contact their
system administrators for every update. We can reword it to instead to
implicitly suggest that they contact their system administrator if
the update has not been applied for "a relatively long time".

Signed-off-by: Diab Neiroukh <lazerl0rd@thezest.dev>
---
  ui/updatepage.go | 2 +-
  zgotext.go       | 2 +-
  2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/ui/updatepage.go b/ui/updatepage.go
index 96fc87f3..76a8dced 100644
--- a/ui/updatepage.go
+++ b/ui/updatepage.go
@@ -65,7 +65,7 @@ func NewUpdatePage() (*UpdatePage, error) {
  	button.SetText(l18n.Sprintf("Update Now"))

  	if !IsAdmin {
-		button.SetText(l18n.Sprintf("Please ask the system administrator to 
update."))
+		button.SetText(l18n.Sprintf("There is an update available. The system 
administrator should update soon."))
  		button.SetEnabled(false)
  		status.SetText(l18n.Sprintf("Status: Waiting for administrator"))
  	}
diff --git a/zgotext.go b/zgotext.go
index efbb9a80..e35974aa 100644
--- a/zgotext.go
+++ b/zgotext.go
@@ -235,7 +235,7 @@ var messageKeyToIndex = map[string]int{
  	"Packet with invalid IP version from %v":                              
  215,
  	"Peer":                                                                
  100,
  	"Persistent keepalive:":                                               
  54,
-	"Please ask the system administrator to update.":                      
  275,
+	"There is an update available. The system administrator should update 
soon.":                         275,
  	"Preshared key:":                                                      
  51,
  	"Protocol version must be 1":                                          
  85,
  	"Public key:":                                                         
  46,
-- 
2.34.0
```

On 2021-11-26 08:47, Jason A. Donenfeld wrote:
> https://git.zx2c4.com/wireguard-windows/commit/?id=8120d07dd5fc9a5e545419fe13490086ce920f31
> 
> Is this okay with both of you?

  reply	other threads:[~2021-11-26  9:18 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-24 15:21 Bruno UT1
2021-11-24 15:42 ` Jason A. Donenfeld
2021-11-25 13:34   ` Diab Neiroukh
2021-11-25 14:23   ` lazerl0rd
2021-11-25 16:07     ` Bruno UT1
2021-11-25 16:27       ` Jason A. Donenfeld
2021-11-26  8:47         ` Jason A. Donenfeld
2021-11-26  9:17           ` lazerl0rd [this message]
2021-11-30 10:12             ` Bruno UT1

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2b0136d9581406195d542696db53d8cd@purelymail.com \
    --to=lazerl0rd@thezest.dev \
    --cc=Jason@zx2c4.com \
    --cc=bandry@ut1.org \
    --cc=wireguard@lists.zx2c4.com \
    --subject='Re: [Windows Client] Out of date Title scare my users' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).