Development discussion of WireGuard
 help / color / mirror / Atom feed
* [PATCH wireguard-windows] l18n: change EnumerationSeparator for Japanese.
@ 2020-02-27  9:43 Eiji Tanioka
  2020-02-27 11:47 ` Simon Rozman
  0 siblings, 1 reply; 2+ messages in thread
From: Eiji Tanioka @ 2020-02-27  9:43 UTC (permalink / raw)
  To: wireguard

I grepped source tree and found that 'EnumerationSeparator' is used
for multiple IP addresses separation. In these situation, comma is
better than "、" in Japanese.
("、" is used for Japanese sentence separator, but separation by comma
is more preferable to enumerate ASCII values.)

Signed-off-by: Eiji Tanioka <tanioka404@gmail.com>
---
 locales/ja/messages.gotext.json | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/locales/ja/messages.gotext.json b/locales/ja/messages.gotext.json
index 3501458..723cb6c 100644
--- a/locales/ja/messages.gotext.json
+++ b/locales/ja/messages.gotext.json
@@ -455,7 +455,7 @@
         {
             "id": "[EnumerationSeparator]",
             "message": "[EnumerationSeparator]",
-            "translation": "、",
+            "translation": ", ",
             "comment": "Inserted between items when listing (e.g. ‘, ’ or ‘、’)"
         },
         {
@@ -1494,4 +1494,4 @@
             ]
         }
     ]
-}
\ No newline at end of file
+}
-- 
2.25.0

_______________________________________________
WireGuard mailing list
WireGuard@lists.zx2c4.com
https://lists.zx2c4.com/mailman/listinfo/wireguard

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH wireguard-windows] l18n: change EnumerationSeparator for Japanese.
  2020-02-27  9:43 [PATCH wireguard-windows] l18n: change EnumerationSeparator for Japanese Eiji Tanioka
@ 2020-02-27 11:47 ` Simon Rozman
  0 siblings, 0 replies; 2+ messages in thread
From: Simon Rozman @ 2020-02-27 11:47 UTC (permalink / raw)
  To: Eiji Tanioka, wireguard


[-- Attachment #1.1: Type: text/plain, Size: 1811 bytes --]

Arigato!

Rebuilt the zgotext.go file, amended to your commit, and applied to sr/l18n patch.

Regards, Simon

-----Original Message-----
From: WireGuard <wireguard-bounces@lists.zx2c4.com> on behalf of Eiji Tanioka <tanioka404@gmail.com>
Date: Thursday, 27 February 2020 at 10:43
To: "wireguard@lists.zx2c4.com" <wireguard@lists.zx2c4.com>
Subject: [PATCH wireguard-windows] l18n: change EnumerationSeparator for Japanese.

    I grepped source tree and found that 'EnumerationSeparator' is used
    for multiple IP addresses separation. In these situation, comma is
    better than "、" in Japanese.
    ("、" is used for Japanese sentence separator, but separation by comma
    is more preferable to enumerate ASCII values.)
    
    Signed-off-by: Eiji Tanioka <tanioka404@gmail.com>
    ---
     locales/ja/messages.gotext.json | 4 ++--
     1 file changed, 2 insertions(+), 2 deletions(-)
    
    diff --git a/locales/ja/messages.gotext.json b/locales/ja/messages.gotext.json
    index 3501458..723cb6c 100644
    --- a/locales/ja/messages.gotext.json
    +++ b/locales/ja/messages.gotext.json
    @@ -455,7 +455,7 @@
             {
                 "id": "[EnumerationSeparator]",
                 "message": "[EnumerationSeparator]",
    -            "translation": "、",
    +            "translation": ", ",
                 "comment": "Inserted between items when listing (e.g. ‘, ’ or ‘、’)"
             },
             {
    @@ -1494,4 +1494,4 @@
                 ]
             }
         ]
    -}
    \ No newline at end of file
    +}
    -- 
    2.25.0
    
    _______________________________________________
    WireGuard mailing list
    WireGuard@lists.zx2c4.com
    https://lists.zx2c4.com/mailman/listinfo/wireguard
    

[-- Attachment #1.2: smime.p7s --]
[-- Type: application/pkcs7-signature, Size: 2965 bytes --]

[-- Attachment #2: Type: text/plain, Size: 148 bytes --]

_______________________________________________
WireGuard mailing list
WireGuard@lists.zx2c4.com
https://lists.zx2c4.com/mailman/listinfo/wireguard

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2020-02-27 11:47 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-27  9:43 [PATCH wireguard-windows] l18n: change EnumerationSeparator for Japanese Eiji Tanioka
2020-02-27 11:47 ` Simon Rozman

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).