From: Mathias Krause <email@example.com> To: "Jason A. Donenfeld" <Jason@zx2c4.com> Cc: WireGuard mailing list <firstname.lastname@example.org> Subject: Re: [PATCH 0/2] wireguard-linux-compat: grsecurity compat patches Date: Mon, 6 Dec 2021 22:00:16 +0100 [thread overview] Message-ID: <email@example.com> (raw) In-Reply-To: <CAHmME9odv1V9wUrLsX16J68wVD3rq+op0VvaNxtsLGG8Rrz4tQ@mail.gmail.com> Am 06.12.21 um 19:55 schrieb Jason A. Donenfeld: > Nice detective work! I just loaded this up on the CI, so we'll see if > this does work across the board. Thanks. > It sounds like the original code also had this bug -- the "r"(out) > should be in the output constraints, not in the input constraints, > right? Sounds like something I should report to the EverCrypt authors > and also fix upstream too then. Yes, probably, but you're mixing up the two. "r"(out) should be an input operand as it's only read in the inline asm. The other two ('tmp' and 'f') are read and written, so need to be output operands (as they already are!) but also marked as earlyclobber ("&") as they're modified before all input operands are read ('out', in this case). It's just a hint to the compiler to not make the register allocation overlap with any (other) input operand register. Thanks, Mathias
next prev parent reply other threads:[~2021-12-06 21:02 UTC|newest] Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-07-06 13:27 Mathias Krause 2021-07-06 13:27 ` [PATCH 1/2] compat: better grsecurity compatibility Mathias Krause 2021-07-06 13:27 ` [PATCH 2/2] curve25519-x86_64: solve register constraints with reserved registers Mathias Krause 2021-08-08 20:53 ` [PATCH 0/2] wireguard-linux-compat: grsecurity compat patches Jason A. Donenfeld 2021-08-09 10:13 ` Mathias Krause 2021-12-03 22:20 ` Jason A. Donenfeld 2021-12-03 22:25 ` Jason A. Donenfeld 2021-12-06 14:04 ` Mathias Krause 2021-12-06 14:48 ` Jason A. Donenfeld 2021-12-06 16:24 ` Mathias Krause 2021-12-06 16:27 ` Jason A. Donenfeld 2021-12-06 18:18 ` Mathias Krause 2021-12-06 18:55 ` Jason A. Donenfeld 2021-12-06 19:28 ` Jason A. Donenfeld 2021-12-06 20:54 ` Mathias Krause 2021-12-08 14:56 ` Jason A. Donenfeld 2021-12-06 21:00 ` Mathias Krause [this message] 2021-12-08 14:56 ` Jason A. Donenfeld 2021-12-09 7:59 ` Mathias Krause 2021-12-10 22:36 ` Jason A. Donenfeld 2021-12-10 22:58 ` Jason A. Donenfeld 2021-12-11 16:35 ` Aymeric Fromherz 2021-12-12 21:43 ` Jason A. Donenfeld 2021-12-13 7:54 ` Mathias Krause 2021-12-13 11:36 ` Jason A. Donenfeld 2021-12-13 16:29 ` Jason A. Donenfeld 2021-12-13 16:46 ` Mathias Krause 2021-12-13 7:44 ` Mathias Krause 2021-12-13 14:20 ` Aymeric Fromherz 2021-12-13 14:33 ` Mathias Krause 2021-12-13 14:37 ` Jason A. Donenfeld 2021-12-13 16:32 ` Mathias Krause 2021-12-13 16:33 ` Jason A. Donenfeld 2021-12-13 16:39 ` Mathias Krause 2021-12-13 16:53 ` Jason A. Donenfeld
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --firstname.lastname@example.org \ --email@example.com \ --cc=Jason@zx2c4.com \ --firstname.lastname@example.org \ --subject='Re: [PATCH 0/2] wireguard-linux-compat: grsecurity compat patches' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).