On 08/09/18 12:18, Julian Orth wrote: > +static bool parse_transit_net(struct wgdevice *device, const char *arg) > +{ > + /* U32 arg -> PID */ > + if (isdigit(*arg)) { > + char *end; > + unsigned long pid = strtoul(arg, &end, 10); > + if (!*end && pid <= UINT32_MAX) { This condition will always be true on a 32-bit system (for a valid integer). I'd prefer strtoull() and `unsigned long long' but given that a valid file descriptor won't ever go that high... eh. shrug. But you'll still get a compiler diagnostic for it.