Development discussion of WireGuard
 help / color / mirror / Atom feed
From: Alexander Lobakin <aleksander.lobakin@intel.com>
To: Jesper Juhl <jesperjuhl76@gmail.com>
Cc: <linux-kernel@vger.kernel.org>, <linux-kselftest@vger.kernel.org>,
	<netdev@vger.kernel.org>, <wireguard@lists.zx2c4.com>,
	"Jason A. Donenfeld" <Jason@zx2c4.com>,
	Shuah Khan <shuah@kernel.org>, Jakub Kicinski <kuba@kernel.org>
Subject: Re: [Patch] [testing][wireguard] Remove unneeded version.h include pointed out by 'make versioncheck'
Date: Thu, 16 Feb 2023 18:05:53 +0100	[thread overview]
Message-ID: <597822c9-b859-7a08-6987-1d8a552f6f32@intel.com> (raw)
In-Reply-To: <83474b0e-9e44-642f-10c9-2e0ff94b06ca@gmail.com>

From: Jesper Juhl <jesperjuhl76@gmail.com>
Date: Thu, 16 Feb 2023 02:01:05 +0100 (CET)

>> From e2fa4955c676960d0809e4afe8273075c94451c9 Mon Sep 17 00:00:00 2001
> From: Jesper Juhl <jesperjuhl76@gmail.com>
> Date: Mon, 13 Feb 2023 02:58:36 +0100
> Subject: [PATCH 06/12] [testing][wireguard] Remove unneeded version.h
> include
>  pointed out by 'make versioncheck'

Your patch is broken, pls resend.
Also I've no idea about the subject/prefix, shouldn't it be like:

[PATCH net-next] wireguard: selftests: remove unneeded version.h

?

> 
> Signed-off-by: Jesper Juhl <jesperjuhl76@gmail.com>
> ---
>  tools/testing/selftests/wireguard/qemu/init.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/tools/testing/selftests/wireguard/qemu/init.c
> b/tools/testing/selftests/wireguard/qemu/init.c
> index 3e49924dd77e..20d8d3192f75 100644
> --- a/tools/testing/selftests/wireguard/qemu/init.c
> +++ b/tools/testing/selftests/wireguard/qemu/init.c
> @@ -24,7 +24,6 @@
>  #include <sys/sysmacros.h>
>  #include <sys/random.h>
>  #include <linux/random.h>
> -#include <linux/version.h>
> 
>  __attribute__((noreturn)) static void poweroff(void)
>  {

Thanks,
Olek

       reply	other threads:[~2023-02-16 17:15 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <83474b0e-9e44-642f-10c9-2e0ff94b06ca@gmail.com>
2023-02-16 17:05 ` Alexander Lobakin [this message]
2023-02-16 17:35 ` Jason A. Donenfeld

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=597822c9-b859-7a08-6987-1d8a552f6f32@intel.com \
    --to=aleksander.lobakin@intel.com \
    --cc=Jason@zx2c4.com \
    --cc=jesperjuhl76@gmail.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=shuah@kernel.org \
    --cc=wireguard@lists.zx2c4.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).