Development discussion of WireGuard
 help / color / mirror / Atom feed
From: Simon Ruderich <simon@ruderich.org>
To: wireguard@lists.zx2c4.com
Subject: [PATCH 1/7] tun: TUNDevice: document behavior of offset parameter
Date: Sun, 31 Dec 2017 17:16:48 +0100	[thread overview]
Message-ID: <65ecab64986a830f029fbf52424a022c6ad081f7.1514726309.git.simon@ruderich.org> (raw)
In-Reply-To: <cover.1514726309.git.simon@ruderich.org>
In-Reply-To: <cover.1514726309.git.simon@ruderich.org>

---
 src/tun.go | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/tun.go b/src/tun.go
index 024f0f0..cb50cd0 100644
--- a/src/tun.go
+++ b/src/tun.go
@@ -17,8 +17,8 @@ const (
 
 type TUNDevice interface {
 	File() *os.File                 // returns the file descriptor of the device
-	Read([]byte, int) (int, error)  // read a packet from the device (without any additional headers)
-	Write([]byte, int) (int, error) // writes a packet to the device (without any additional headers)
+	Read([]byte, int) (int, error)  // read a packet from the device (without any additional headers); packet starts at the given offset (however data preceding offset may be overwritten!)
+	Write([]byte, int) (int, error) // writes a packet to the device (without any additional headers); packet starts at the given offset (however data preceding offset may be overwritten!)
 	MTU() (int, error)              // returns the MTU of the device
 	Name() string                   // returns the current name
 	Events() chan TUNEvent          // returns a constant channel of events related to the device
-- 
2.15.1

  reply	other threads:[~2017-12-31 16:16 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-31 16:16 [PATCH 0/7] TUN fixes Simon Ruderich
2017-12-31 16:16 ` Simon Ruderich [this message]
2017-12-31 16:16 ` [PATCH 2/7] tun_linux: add PIHeaderSize constant instead of magic value Simon Ruderich
2017-12-31 16:16 ` [PATCH 3/7] tun_linux: document packet information header values Simon Ruderich
2017-12-31 16:16 ` [PATCH 4/7] helper_test: reorder DummyTUN functions to follow interface order Simon Ruderich
2017-12-31 16:16 ` [PATCH 5/7] helper_test: adapt to TUNDevice interface change Simon Ruderich
2017-12-31 16:16 ` [PATCH 6/7] tun_darwin: " Simon Ruderich
2017-12-31 16:16 ` [PATCH 7/7] " Simon Ruderich
2017-12-31 19:17   ` Mathias Hall-Andersen
2018-01-01 11:14     ` Simon Ruderich
2018-01-01 11:36     ` Simon Ruderich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=65ecab64986a830f029fbf52424a022c6ad081f7.1514726309.git.simon@ruderich.org \
    --to=simon@ruderich.org \
    --cc=wireguard@lists.zx2c4.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).