Development discussion of WireGuard
 help / color / mirror / Atom feed
From: Mathias Hall-Andersen <mathias@hall-andersen.dk>
To: "Aurélien Chabot" <aurelien@chabot.fr>
Cc: wireguard@lists.zx2c4.com
Subject: Re: WireGuard root-less support for android
Date: Wed, 8 Nov 2017 18:44:01 +0100	[thread overview]
Message-ID: <68455df5-a429-09aa-308d-fc3615557530@hall-andersen.dk> (raw)
In-Reply-To: <20171107043817.9050-1-aurelien@chabot.fr>

Hi Aurélien

Thanks for contributing to the wireguard-go project.

I never anticipated for the implementation to be used as a library.
This means that I either have to:

1. Settle for an API and reconsider what is exported and not.
2. Give no guarantees about API stability

Providing the functionality as a library might be the cleanest solution
in this case.
One option is to have an internal package and a small exported API.

Is the GetUDPConn only used to wait for the device to bind?

The missing device.tun.device.Close() is indeed a bug.

I will look more at your patches during the weekend,
Thanks once again.

Mathias

  parent reply	other threads:[~2017-11-08 17:40 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-07  4:38 Aurélien Chabot
2017-11-07  4:38 ` [PATCH 1/4] Add wireguard-go as submodule Aurélien Chabot
2017-11-07  9:34   ` Greg KH
2017-11-07  9:53     ` Jason A. Donenfeld
2017-11-07  4:38 ` [PATCH 2/4] Add support for android in wireguard-go Aurélien Chabot
2017-11-07  4:38 ` [PATCH 3/4] Add support of wireguard-go as an Android Vpn Service Aurélien Chabot
2017-11-07  4:38 ` [PATCH 4/4] Add build instruction Aurélien Chabot
2017-11-07  4:38 ` [PATCH 1/2] Put the code in a 'wireguard' go package Aurélien Chabot
2017-11-07  4:38 ` [PATCH 2/2] Add android support Aurélien Chabot
2017-11-07  9:57 ` WireGuard root-less support for android Jason A. Donenfeld
2017-11-08  5:15 ` Samuel Holland
2017-11-08 17:44 ` Mathias Hall-Andersen [this message]
2017-11-08 21:50   ` Aurélien Chabot
2018-01-23  1:52     ` Aurélien Chabot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=68455df5-a429-09aa-308d-fc3615557530@hall-andersen.dk \
    --to=mathias@hall-andersen.dk \
    --cc=aurelien@chabot.fr \
    --cc=wireguard@lists.zx2c4.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).