Development discussion of WireGuard
 help / color / mirror / Atom feed
From: "Jörg Thalheim" <joerg@higgsboson.tk>
To: wireguard@lists.zx2c4.com
Subject: Re: [PATCH] wg: correct type for CTRL_ATTR_FAMILY_ID
Date: Tue, 31 Oct 2017 09:00:03 +0000	[thread overview]
Message-ID: <77ff13e2-e375-c8d2-6ef2-8a18e5ff5577@higgsboson.tk> (raw)
In-Reply-To: <462fb5c1-0832-a394-8839-d9b54bcb13fa@thalheim.io>

sorry for the duplicate messages. I had to resend this patch due wrong sender address and the resend dialog was a bit confusing.

On 2017-10-31 08:55, Jörg Thalheim wrote:
> Signed-off-by: Joerg Thalheim <joerg@thalheim.io>
> ---
>  src/tools/mnlg.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/src/tools/mnlg.c b/src/tools/mnlg.c
> index 9135651..5ac72e2 100644
> --- a/src/tools/mnlg.c
> +++ b/src/tools/mnlg.c
> @@ -19,7 +19,7 @@
>  struct mnlg_socket {
>  	struct mnl_socket *nl;
>  	char *buf;
> -	uint32_t id;
> +	uint16_t id;
>  	uint8_t version;
>  	unsigned int seq;
>  	unsigned int portid;
> @@ -206,7 +206,7 @@ int mnlg_socket_group_add(struct mnlg_socket *nlg, const char *group_name)
>   	nlh = __mnlg_msg_prepare(nlg, CTRL_CMD_GETFAMILY,
>  				 NLM_F_REQUEST | NLM_F_ACK, GENL_ID_CTRL, 1);
> -	mnl_attr_put_u32(nlh, CTRL_ATTR_FAMILY_ID, nlg->id);
> +	mnl_attr_put_u16(nlh, CTRL_ATTR_FAMILY_ID, nlg->id);
>   	err = mnlg_socket_send(nlg, nlh);
>  	if (err < 0)

  reply	other threads:[~2017-10-31  8:57 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-31  8:55 Jörg Thalheim
2017-10-31  9:00 ` Jörg Thalheim [this message]
2017-10-31  9:19 ` Jason A. Donenfeld
2017-10-31 13:52   ` Jason A. Donenfeld
2017-10-31 13:57     ` Jason A. Donenfeld

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=77ff13e2-e375-c8d2-6ef2-8a18e5ff5577@higgsboson.tk \
    --to=joerg@higgsboson.tk \
    --cc=wireguard@lists.zx2c4.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).