From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.zx2c4.com (lists.zx2c4.com [165.227.139.114]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E033DC54E67 for ; Wed, 20 Mar 2024 12:41:48 +0000 (UTC) Received: by lists.zx2c4.com (ZX2C4 Mail Server) with ESMTP id 3264d11c; Wed, 20 Mar 2024 12:41:46 +0000 (UTC) Received: from gandalf.ozlabs.org (mail.ozlabs.org [2404:9400:2221:ea00::3]) by lists.zx2c4.com (ZX2C4 Mail Server) with ESMTPS id a5ceee7a (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO) for ; Wed, 20 Mar 2024 12:41:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ellerman.id.au; s=201909; t=1710938498; bh=aAUO3lBXXGEBX6m0mDWiKt/o6NIO+aW9sgNR3bVCTzM=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=pDysZXTzTiDSH5YK83UMRNylp4bt3GRo9FqWpe4cSIZaBBNSpjoWU4c8LgsbhE/fO X6odEhE6xCTe/ljsHRjTiypNHXMRrRuLN0Jzr1ijy3wx6sdbjDAAD6ANTVsuiYgGqP KvdJhqtU/7p0prvn4cQit8rb/kknkkiYK+gl00l6bCaMDfld2Dz0EUNFKN6MHmgSHr fpNcLtH5iVCiEo35T2c6jwEPJ3CF5cW8uG2cIgdO2A/Kq43uA9A2L4REaElcaavRkI YYc2ExUMozicvZxsnZ7AMzsh69Li6ZSVxoSj4g4xx/z/0NrXlCrzaOmeJa1qSBOLvi mHIZqaIMWlFng== Received: from authenticated.ozlabs.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.ozlabs.org (Postfix) with ESMTPSA id 4V07WP12Rxz4wcQ; Wed, 20 Mar 2024 23:41:36 +1100 (AEDT) From: Michael Ellerman To: Michal =?utf-8?Q?Such=C3=A1nek?= Cc: netdev@vger.kernel.org, "Jason A. Donenfeld" , linuxppc-dev@lists.ozlabs.org, wireguard@lists.zx2c4.com, dtsen@linux.ibm.com, Herbert Xu Subject: Re: Cannot load wireguard module In-Reply-To: <20240319124742.GM20665@kitsune.suse.cz> References: <20240315122005.GG20665@kitsune.suse.cz> <87jzm32h7q.fsf@mail.lhotse> <87r0g7zrl2.fsf@mail.lhotse> <20240318170855.GK20665@kitsune.suse.cz> <20240319124742.GM20665@kitsune.suse.cz> Date: Wed, 20 Mar 2024 23:41:32 +1100 Message-ID: <87le6dyt1f.fsf@mail.lhotse> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: wireguard@lists.zx2c4.com X-Mailman-Version: 2.1.30rc1 Precedence: list List-Id: Development discussion of WireGuard List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: wireguard-bounces@lists.zx2c4.com Sender: "WireGuard" Michal Such=C3=A1nek writes: > On Mon, Mar 18, 2024 at 06:08:55PM +0100, Michal Such=C3=A1nek wrote: >> On Mon, Mar 18, 2024 at 10:50:49PM +1100, Michael Ellerman wrote: >> > Michael Ellerman writes: >> > > Michal Such=C3=A1nek writes: >> > >> Hello, >> > >> >> > >> I cannot load the wireguard module. >> > >> >> > >> Loading the module provides no diagnostic other than 'No such devic= e'. >> > >> >> > >> Please provide maningful diagnostics for loading software-only driv= er, >> > >> clearly there is no particular device needed. >> > > >> > > Presumably it's just bubbling up an -ENODEV from somewhere. >> > > >> > > Can you get a trace of it? >> > > >> > > Something like: >> > > >> > > # trace-cmd record -p function_graph -F modprobe wireguard > > Attached. Sorry :/, you need to also trace children of modprobe, with -c. But, I was able to reproduce the same issue here. On a P9, a kernel with CONFIG_CRYPTO_CHACHA20_P10=3Dn everything works: $ modprobe -v wireguard insmod /lib/modules/6.8.0/kernel/net/ipv4/udp_tunnel.ko insmod /lib/modules/6.8.0/kernel/net/ipv6/ip6_udp_tunnel.ko insmod /lib/modules/6.8.0/kernel/lib/crypto/libchacha.ko insmod /lib/modules/6.8.0/kernel/lib/crypto/libchacha20poly1305.ko insmod /lib/modules/6.8.0/kernel/drivers/net/wireguard/wireguard.ko [ 19.180564][ T692] wireguard: allowedips self-tests: pass [ 19.185080][ T692] wireguard: nonce counter self-tests: pass [ 19.310438][ T692] wireguard: ratelimiter self-tests: pass [ 19.310639][ T692] wireguard: WireGuard 1.0.0 loaded. See www.wiregua= rd.com for information. [ 19.310746][ T692] wireguard: Copyright (C) 2015-2019 Jason A. Donenf= eld . All Rights Reserved. If I build CONFIG_CRYPTO_CHACHA20_P10 as a module then it breaks: $ modprobe -v wireguard insmod /lib/modules/6.8.0/kernel/net/ipv4/udp_tunnel.ko insmod /lib/modules/6.8.0/kernel/net/ipv6/ip6_udp_tunnel.ko insmod /lib/modules/6.8.0/kernel/lib/crypto/libchacha.ko insmod /lib/modules/6.8.0/kernel/arch/powerpc/crypto/chacha-p10-crypto.ko modprobe: ERROR: could not insert 'wireguard': No such device The ENODEV is coming from module_cpu_feature_match(), which blocks the driver from loading on non-p10. Looking at other arches (arm64 at least) it seems like the driver should instead be loading but disabling the p10 path. Which then allows chacha_crypt_arch() to exist, and it has a fallback to use chacha_crypt_generic(). I don't see how module_cpu_feature_match() can co-exist with the driver also providing a fallback. Hopefully someone who knows crypto better than me can explain it. This diff fixes it for me: diff --git a/arch/powerpc/crypto/chacha-p10-glue.c b/arch/powerpc/crypto/ch= acha-p10-glue.c index 74fb86b0d209..9d2c30b0904c 100644 --- a/arch/powerpc/crypto/chacha-p10-glue.c +++ b/arch/powerpc/crypto/chacha-p10-glue.c @@ -197,6 +197,9 @@ static struct skcipher_alg algs[] =3D { =20 static int __init chacha_p10_init(void) { + if (!cpu_has_feature(PPC_FEATURE2_ARCH_3_1)) + return 0; + static_branch_enable(&have_p10); =20 return crypto_register_skciphers(algs, ARRAY_SIZE(algs)); @@ -207,7 +210,7 @@ static void __exit chacha_p10_exit(void) crypto_unregister_skciphers(algs, ARRAY_SIZE(algs)); } =20 -module_cpu_feature_match(PPC_MODULE_FEATURE_P10, chacha_p10_init); +module_init(chacha_p10_init); module_exit(chacha_p10_exit); =20 MODULE_DESCRIPTION("ChaCha and XChaCha stream ciphers (P10 accelerated)"); Giving me: $ modprobe -v wireguard insmod /lib/modules/6.8.0-dirty/kernel/net/ipv4/udp_tunnel.ko insmod /lib/modules/6.8.0-dirty/kernel/net/ipv6/ip6_udp_tunnel.ko insmod /lib/modules/6.8.0-dirty/kernel/lib/crypto/libchacha.ko insmod /lib/modules/6.8.0-dirty/kernel/arch/powerpc/crypto/chacha-p10-cry= pto.ko insmod /lib/modules/6.8.0-dirty/kernel/lib/crypto/libchacha20poly1305.ko insmod /lib/modules/6.8.0-dirty/kernel/drivers/net/wireguard/wireguard.ko [ 19.657941][ T718] wireguard: allowedips self-tests: pass [ 19.662501][ T718] wireguard: nonce counter self-tests: pass [ 19.782933][ T718] wireguard: ratelimiter self-tests: pass [ 19.783114][ T718] wireguard: WireGuard 1.0.0 loaded. See www.wiregua= rd.com for information. [ 19.783223][ T718] wireguard: Copyright (C) 2015-2019 Jason A. Donenf= eld . All Rights Reserved. =20=20 cheers