Development discussion of WireGuard
 help / color / mirror / Atom feed
From: Gabriel Augendre <gabriel@augendre.info>
To: wireguard@lists.zx2c4.com
Subject: macOS on-demand Wi-Fi space at the beginning of SSID doesn't work as expected
Date: Thu, 16 Mar 2023 17:58:45 +0100	[thread overview]
Message-ID: <8DFC7AF6-8476-421B-93BC-766C6714E178@augendre.info> (raw)

Hello,

I hope this is the right place to submit what, in my opinion, is a bug.

I'm using Wireguard on macOS, installed from the App Store[1].
App version: 1.0.16 (27)
Go backend version: 1e2c3e5a

[1]: https://apps.apple.com/fr/app/wireguard/id1451685025?mt=12

I'm unable to add an SSID starting with a space in the on-demand except/only configuration. The app strips the whitespace at the beginning of the SSID.

Steps to reproduce:
1. Install WireGuard
2. Setup a tunnel
3. Enable On-Demand Wi-Fi
4. Select "Only these SSIDs" or "Except these SSIDs"
5. Type an SSID name starting with a space
6. Type Enter or Tab to validate the selection

Notice how the space at the beginning of the SSID has disappeared in the text box. Also, the configuration treats the SSID with no space at the beginning. If you opted for "only" this SSID and you're connected to it, then WireGuard won't connect. If you selected "except", then WireGuard will connect anyway.

The iOS app doesn't seem affected by this bug. Selecting a known SSID starting with a space works as expected.

I'd be glad to contribute a patch but I have no experience in Swift programming.
I'm guessing the issue lies somewhere in Sources/WireGuardApp/UI/ActivateOnDemandViewModel.swift though.

Regards,

-- 
Gabriel Augendre


                 reply	other threads:[~2023-03-23 16:38 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8DFC7AF6-8476-421B-93BC-766C6714E178@augendre.info \
    --to=gabriel@augendre.info \
    --cc=wireguard@lists.zx2c4.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).