From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 64202C433FE for ; Sun, 13 Dec 2020 14:23:35 +0000 (UTC) Received: from krantz.zx2c4.com (krantz.zx2c4.com [192.95.5.69]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6995D22D2B for ; Sun, 13 Dec 2020 14:23:34 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6995D22D2B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=wireguard-bounces@lists.zx2c4.com Received: by krantz.zx2c4.com (ZX2C4 Mail Server) with ESMTP id 124a5b06; Sun, 13 Dec 2020 14:15:06 +0000 (UTC) Received: from mail-oo1-xc43.google.com (mail-oo1-xc43.google.com [2607:f8b0:4864:20::c43]) by krantz.zx2c4.com (ZX2C4 Mail Server) with ESMTPS id a0083df0 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO) for ; Sun, 13 Dec 2020 12:47:43 +0000 (UTC) Received: by mail-oo1-xc43.google.com with SMTP id w9so3315107ooh.13 for ; Sun, 13 Dec 2020 04:55:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:autocrypt:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=7hjE0eiFvPerzKGNP58EBfWNvonykp96rfUMfWh51Wk=; b=lHAPLktk8CPNJMgrz4pKIMnN2Y+fE7ksYs3p+CT4Vwgx1IUUe3h8T7y8zsfwn0RFB/ dewv+8gKzJTsZgeVEO4qmcoDqUrBSvVVe4ekpibhSMxUF79qHFvlz8Xrh8N9n4925mrg l0etATtDRQUYbrE4l03EVZFbg0DsNG0C4CT+zW9rXEN4cMVqrdZMXYF4nnrrr/82xAfZ fmnN6Khxe10+DkYAa3bDQ5Tz6nj555/mRV4vveGbCRTNYwGaM7qFWBX9U8LqPrZIuijM u/iMYA/Q9jcMjuOT7kMihGcKeAFOQijD1oCO6QLJUP8ypk6VwUw2iWBlLnON3SUVqZK3 pHFQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:autocrypt :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=7hjE0eiFvPerzKGNP58EBfWNvonykp96rfUMfWh51Wk=; b=Ws/IBLmRqJz1jPAagNumrVKveNxoRUkG8hFFy/NakCFr91smYI0yd02R0nuUfSlYPa EpIjpzFQ/0WWatVjLQGXU3STOp9kjP9In7TgCQrwbMzvITyIHgJQlSvMWjyBHbYlr87C iz/ixom7YAoouDE15XcVJHqs1klxytAiTCB1T1JyRGB8y1zSzUsx7VY37lbYTZnZjvN4 piTEgsf+vuUsu0ASCU3Hqum1Yu0m7JXtgNP430NGSqQylmFVCKXEQI++q+ZD970YmTT6 ZM7Tzv4XtkmIheazoXVPwxohPovwWXpaKWhEgV0qJRPOB+GZYz6tgs7ZLkunv2Vt8u8y xNZg== X-Gm-Message-State: AOAM530kivWVinkEUdabZXl+UzihHXFNskV1D4+ErC+bjSZIqlgF+GfY cjoS19k8CBp/yyFDAXJ8hfrbBPGXU60= X-Google-Smtp-Source: ABdhPJwK+nvfO6OpMojQu0KbNPWdxfwoUGIzmjc8Kh15k6e/6rKI0GEuFnT/E46g6qBdvS+8BRkYLg== X-Received: by 2002:a4a:6154:: with SMTP id u20mr11295517ooe.12.1607864142162; Sun, 13 Dec 2020 04:55:42 -0800 (PST) Received: from server.roeck-us.net ([2600:1700:e321:62f0:329c:23ff:fee3:9d7c]) by smtp.gmail.com with ESMTPSA id i16sm3458482otc.61.2020.12.13.04.55.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 13 Dec 2020 04:55:41 -0800 (PST) Subject: Re: [PATCH v3] Compiler Attributes: remove CONFIG_ENABLE_MUST_CHECK To: Miguel Ojeda Cc: Masahiro Yamada , "Jason A . Donenfeld" , Nathan Chancellor , Nick Desaulniers , Shuah Khan , clang-built-linux , linux-kernel , "open list:KERNEL SELFTEST FRAMEWORK" , Network Development , wireguard@lists.zx2c4.com References: <20201128193335.219395-1-masahiroy@kernel.org> <20201212161831.GA28098@roeck-us.net> From: Guenter Roeck Autocrypt: addr=linux@roeck-us.net; keydata= xsFNBE6H1WcBEACu6jIcw5kZ5dGeJ7E7B2uweQR/4FGxH10/H1O1+ApmcQ9i87XdZQiB9cpN RYHA7RCEK2dh6dDccykQk3bC90xXMPg+O3R+C/SkwcnUak1UZaeK/SwQbq/t0tkMzYDRxfJ7 nyFiKxUehbNF3r9qlJgPqONwX5vJy4/GvDHdddSCxV41P/ejsZ8PykxyJs98UWhF54tGRWFl 7i1xvaDB9lN5WTLRKSO7wICuLiSz5WZHXMkyF4d+/O5ll7yz/o/JxK5vO/sduYDIlFTvBZDh gzaEtNf5tQjsjG4io8E0Yq0ViobLkS2RTNZT8ICq/Jmvl0SpbHRvYwa2DhNsK0YjHFQBB0FX IdhdUEzNefcNcYvqigJpdICoP2e4yJSyflHFO4dr0OrdnGLe1Zi/8Xo/2+M1dSSEt196rXaC kwu2KgIgmkRBb3cp2vIBBIIowU8W3qC1+w+RdMUrZxKGWJ3juwcgveJlzMpMZNyM1jobSXZ0 VHGMNJ3MwXlrEFPXaYJgibcg6brM6wGfX/LBvc/haWw4yO24lT5eitm4UBdIy9pKkKmHHh7s jfZJkB5fWKVdoCv/omy6UyH6ykLOPFugl+hVL2Prf8xrXuZe1CMS7ID9Lc8FaL1ROIN/W8Vk BIsJMaWOhks//7d92Uf3EArDlDShwR2+D+AMon8NULuLBHiEUQARAQABzTJHdWVudGVyIFJv ZWNrIChMaW51eCBhY2NvdW50KSA8bGludXhAcm9lY2stdXMubmV0PsLBgQQTAQIAKwIbAwYL CQgHAwIGFQgCCQoLBBYCAwECHgECF4ACGQEFAlVcphcFCRmg06EACgkQyx8mb86fmYFg0RAA nzXJzuPkLJaOmSIzPAqqnutACchT/meCOgMEpS5oLf6xn5ySZkl23OxuhpMZTVX+49c9pvBx hpvl5bCWFu5qC1jC2eWRYU+aZZE4sxMaAGeWenQJsiG9lP8wkfCJP3ockNu0ZXXAXwIbY1O1 c+l11zQkZw89zNgWgKobKzrDMBFOYtAh0pAInZ9TSn7oA4Ctejouo5wUugmk8MrDtUVXmEA9 7f9fgKYSwl/H7dfKKsS1bDOpyJlqhEAH94BHJdK/b1tzwJCFAXFhMlmlbYEk8kWjcxQgDWMu GAthQzSuAyhqyZwFcOlMCNbAcTSQawSo3B9yM9mHJne5RrAbVz4TWLnEaX8gA5xK3uCNCeyI sqYuzA4OzcMwnnTASvzsGZoYHTFP3DQwf2nzxD6yBGCfwNGIYfS0i8YN8XcBgEcDFMWpOQhT Pu3HeztMnF3HXrc0t7e5rDW9zCh3k2PA6D2NV4fews9KDFhLlTfCVzf0PS1dRVVWM+4jVl6l HRIAgWp+2/f8dx5vPc4Ycp4IsZN0l1h9uT7qm1KTwz+sSl1zOqKD/BpfGNZfLRRxrXthvvY8 BltcuZ4+PGFTcRkMytUbMDFMF9Cjd2W9dXD35PEtvj8wnEyzIos8bbgtLrGTv/SYhmPpahJA l8hPhYvmAvpOmusUUyB30StsHIU2LLccUPPOwU0ETofVZwEQALlLbQeBDTDbwQYrj0gbx3bq 7kpKABxN2MqeuqGr02DpS9883d/t7ontxasXoEz2GTioevvRmllJlPQERVxM8gQoNg22twF7 pB/zsrIjxkE9heE4wYfN1AyzT+AxgYN6f8hVQ7Nrc9XgZZe+8IkuW/Nf64KzNJXnSH4u6nJM J2+Dt274YoFcXR1nG76Q259mKwzbCukKbd6piL+VsT/qBrLhZe9Ivbjq5WMdkQKnP7gYKCAi pNVJC4enWfivZsYupMd9qn7Uv/oCZDYoBTdMSBUblaLMwlcjnPpOYK5rfHvC4opxl+P/Vzyz 6WC2TLkPtKvYvXmdsI6rnEI4Uucg0Au/Ulg7aqqKhzGPIbVaL+U0Wk82nz6hz+WP2ggTrY1w ZlPlRt8WM9w6WfLf2j+PuGklj37m+KvaOEfLsF1v464dSpy1tQVHhhp8LFTxh/6RWkRIR2uF I4v3Xu/k5D0LhaZHpQ4C+xKsQxpTGuYh2tnRaRL14YMW1dlI3HfeB2gj7Yc8XdHh9vkpPyuT nY/ZsFbnvBtiw7GchKKri2gDhRb2QNNDyBnQn5mRFw7CyuFclAksOdV/sdpQnYlYcRQWOUGY HhQ5eqTRZjm9z+qQe/T0HQpmiPTqQcIaG/edgKVTUjITfA7AJMKLQHgp04Vylb+G6jocnQQX JqvvP09whbqrABEBAAHCwWUEGAECAA8CGwwFAlVcpi8FCRmg08MACgkQyx8mb86fmYHNRQ/+ J0OZsBYP4leJvQF8lx9zif+v4ZY/6C9tTcUv/KNAE5leyrD4IKbnV4PnbrVhjq861it/zRQW cFpWQszZyWRwNPWUUz7ejmm9lAwPbr8xWT4qMSA43VKQ7ZCeTQJ4TC8kjqtcbw41SjkjrcTG wF52zFO4bOWyovVAPncvV9eGA/vtnd3xEZXQiSt91kBSqK28yjxAqK/c3G6i7IX2rg6pzgqh hiH3/1qM2M/LSuqAv0Rwrt/k+pZXE+B4Ud42hwmMr0TfhNxG+X7YKvjKC+SjPjqp0CaztQ0H nsDLSLElVROxCd9m8CAUuHplgmR3seYCOrT4jriMFBtKNPtj2EE4DNV4s7k0Zy+6iRQ8G8ng QjsSqYJx8iAR8JRB7Gm2rQOMv8lSRdjva++GT0VLXtHULdlzg8VjDnFZ3lfz5PWEOeIMk7Rj trjv82EZtrhLuLjHRCaG50OOm0hwPSk1J64R8O3HjSLdertmw7eyAYOo4RuWJguYMg5DRnBk WkRwrSuCn7UG+qVWZeKEsFKFOkynOs3pVbcbq1pxbhk3TRWCGRU5JolI4ohy/7JV1TVbjiDI HP/aVnm6NC8of26P40Pg8EdAhajZnHHjA7FrJXsy3cyIGqvg9os4rNkUWmrCfLLsZDHD8FnU mDW4+i+XlNFUPUYMrIKi9joBhu18ssf5i5Q= Message-ID: <8f645b94-80e5-529c-7b6a-d9b8d8c9685e@roeck-us.net> Date: Sun, 13 Dec 2020 04:55:39 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Mailman-Approved-At: Sun, 13 Dec 2020 15:15:04 +0100 X-BeenThere: wireguard@lists.zx2c4.com X-Mailman-Version: 2.1.30rc1 Precedence: list List-Id: Development discussion of WireGuard List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: wireguard-bounces@lists.zx2c4.com Sender: "WireGuard" On 12/12/20 9:04 PM, Miguel Ojeda wrote: > On Sat, Dec 12, 2020 at 5:18 PM Guenter Roeck wrote: >> >> This patch results in: >> >> arch/sh/kernel/cpu/sh4a/smp-shx3.c: In function 'shx3_prepare_cpus': >> arch/sh/kernel/cpu/sh4a/smp-shx3.c:76:3: error: ignoring return value of 'request_irq' declared with attribute 'warn_unused_result' >> >> when building sh:defconfig. Checking for calls to request_irq() >> suggests that there will be other similar errors in various builds. >> Reverting the patch fixes the problem. > > Which ones? From a quick grep and some filtering I could only find one > file with wrong usage apart from this one: > > drivers/net/ethernet/lantiq_etop.c: > request_irq(irq, ltq_etop_dma_irq, 0, "etop_tx", priv); > drivers/net/ethernet/lantiq_etop.c: > request_irq(irq, ltq_etop_dma_irq, 0, "etop_rx", priv); > > Of course, this does not cover other functions, but it means there > aren't many issues and/or people building the code if nobody complains > within a few weeks. So I think we can fix them as they come. > Witz komm raus, Du bist umzingelt. The key here is "if nobody complains". I would argue that it is _your_ responsibility to do those builds, and not the reponsibility of others to do it for you. But, sure, your call. Please feel free to ignore my report. Guenter