Development discussion of WireGuard
 help / color / mirror / Atom feed
From: Simon Rozman <simon@rozman.si>
To: Arjen Brouwer <arjenjb@gmail.com>,
	"wireguard@lists.zx2c4.com" <wireguard@lists.zx2c4.com>
Subject: Re: [PATCH] DO_NOT_LAUNCH parameter was ignored by MSI, should work now
Date: Thu, 27 Feb 2020 11:40:20 +0000	[thread overview]
Message-ID: <AE60ED0F-6F29-43E2-9565-D61998256B85@rozman.si> (raw)
In-Reply-To: <20200224133237.953-1-arjenjb@gmail.com>


[-- Attachment #1.1: Type: text/plain, Size: 3474 bytes --]

Hi Arjen,

I was not able to reproduce the problem your patch was supposed to solve.

Running:
msiexec /i https://download.wireguard.com/windows-client/wireguard-amd64-0.0.38.msi /l* setup.log DO_NOT_LAUNCH=1
did not launch the WireGuard after setup was complete. Screencast here: https://1drv.ms/v/s!AsRKV9itoeUTi0Y-LT895Ynvh0da

Running the same command in elevated prompt neither. Screen cast here: https://1drv.ms/v/s!AsRKV9itoeUTi0cEkCG_n2FEX1WA

When adding /qn to completely silence the MSI progress neither. Screen cast here: https://1drv.ms/v/s!AsRKV9itoeUTi0izY000CEIE4axC

So, how were you setting the `DO_NOT_LAUNCH` property in the first place?

Regards,
Simon

-----Original Message-----
From: WireGuard <wireguard-bounces@lists.zx2c4.com> on behalf of Arjen Brouwer <arjenjb@gmail.com>
Date: Tuesday, 25 February 2020 at 01:51
To: "wireguard@lists.zx2c4.com" <wireguard@lists.zx2c4.com>
Cc: Arjen Brouwer <arjen@ag5.nl>
Subject: [PATCH] DO_NOT_LAUNCH parameter was ignored by MSI, should work now

    From: Arjen Brouwer <arjen@ag5.nl>
    
    
    The `DO_NO_LAUNCH` parameter did not actually work. After running the installer with the DO_NO_LAUNCH parameter, the UI still showed up afterwards and the MSI log had the following entry:
    
    ```
    MSI (c) (28:08) [14:43:17:966]: Ignoring disallowed property DO_NOT_LAUNCH
    ```
    
    By explicitly defining the DO_NOT_LAUNCH property and making it secure, solved the problem.
    
    ---
     installer/wireguard.wxs | 7 ++++---
     1 file changed, 4 insertions(+), 3 deletions(-)
    
    diff --git a/installer/wireguard.wxs b/installer/wireguard.wxs
    index 5bbb1eb..781d20c 100644
    --- a/installer/wireguard.wxs
    +++ b/installer/wireguard.wxs
    @@ -45,7 +45,8 @@
     		<Property Id="DISABLEROLLBACK" Value="yes" />
     		<Property Id="MSIDISABLERMRESTART" Value="1" />
     		<Property Id="MSIRMSHUTDOWN" Value="1" />
    -
    +		<Property Id="DO_NOT_LAUNCH" Value="0" Secure="yes" />
    +
     		<!--
     			Upgrading
     		-->
    @@ -135,7 +136,7 @@
     		-->
     		<CustomAction Id="LaunchApplication" HideTarget="yes" Impersonate="no" Execute="deferred" FileKey="wireguard.exe" ExeCommand="" Return="asyncNoWait" />
     		<InstallExecuteSequence>
    -			<Custom Action="LaunchApplication" Before="InstallFinalize">(&amp;WireGuardFeature = 3) AND NOT DO_NOT_LAUNCH</Custom>
    +			<Custom Action="LaunchApplication" Before="InstallFinalize"><![CDATA[(&WireGuardFeature = 3) AND (DO_NOT_LAUNCH = "0")]]></Custom>
     		</InstallExecuteSequence>
     
     		<!--
    @@ -143,7 +144,7 @@
     		-->
     		<CustomAction Id="LaunchApplicationAsOrdinaryUser" HideTarget="yes" FileKey="wireguard.exe" ExeCommand="" Return="asyncNoWait" />
     		<InstallExecuteSequence>
    -			<Custom Action="LaunchApplicationAsOrdinaryUser" After="InstallFinalize">(&amp;WireGuardFeature = -1) AND (!WireGuardFeature = 3) AND NOT DO_NOT_LAUNCH</Custom>
    +			<Custom Action="LaunchApplicationAsOrdinaryUser" After="InstallFinalize"><![CDATA[(&WireGuardFeature = -1) AND (!WireGuardFeature = 3) AND (DO_NOT_LAUNCH = "0")]]></Custom>
     		</InstallExecuteSequence>
     	</Product>
     </Wix>
    -- 
    2.24.1.windows.2
    
    _______________________________________________
    WireGuard mailing list
    WireGuard@lists.zx2c4.com
    https://lists.zx2c4.com/mailman/listinfo/wireguard
    

[-- Attachment #1.2: smime.p7s --]
[-- Type: application/pkcs7-signature, Size: 2965 bytes --]

[-- Attachment #2: Type: text/plain, Size: 148 bytes --]

_______________________________________________
WireGuard mailing list
WireGuard@lists.zx2c4.com
https://lists.zx2c4.com/mailman/listinfo/wireguard

      reply	other threads:[~2020-02-27 11:40 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-24 13:32 Arjen Brouwer
2020-02-27 11:40 ` Simon Rozman [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=AE60ED0F-6F29-43E2-9565-D61998256B85@rozman.si \
    --to=simon@rozman.si \
    --cc=arjenjb@gmail.com \
    --cc=wireguard@lists.zx2c4.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).