FreeBSD current socket-src changed. Wireguard not compiling.

FreeBSD current socket-src changed. Wireguard not compiling.

[Michael Pro]

Tonight after updating kernel freebsd current I got coredump with
wireguard enabled kernel module.

As is
https://reviews.freebsd.org/D36232
 D36232 protosw: refactor protosw and domain static declaration and
load (freebsd.org)
in wireguard-freebsd/src/support.h
...
error = (*so->so_proto->pr_usrreqs->pru_sockaddr)(so, nam);
...
replace to
...
error = solisten_proto_check(so);
...
Recompile - no more core dumps. All works now, perhaps...

Is this the right way to fix the problem? Is this enough or should we
wait for a full-scale refactoring of the code?

Thanks in advance for your reply.

Re: FreeBSD current socket-src changed. Wireguard not compiling.

[Jason A. Donenfeld]

On Tue, Aug 23, 2022 at 12:26:21PM +0300, Michael Pro wrote:
> Tonight after updating kernel freebsd current I got coredump with
> wireguard enabled kernel module.
> 
> As is
> https://reviews.freebsd.org/D36232
>  D36232 protosw: refactor protosw and domain static declaration and
> load (freebsd.org)
> in wireguard-freebsd/src/support.h
> ...
> error = (*so->so_proto->pr_usrreqs->pru_sockaddr)(so, nam);
> ...
> replace to
> ...
> error = solisten_proto_check(so);
> ...
> Recompile - no more core dumps. All works now, perhaps...
> 
> Is this the right way to fix the problem? Is this enough or should we
> wait for a full-scale refactoring of the code?
> 
> Thanks in advance for your reply.

Thanks. Is there a __FreeBSD_version__ change that corresponds?

Jason

Re: FreeBSD current socket-src changed. Wireguard not compiling.

[Ed Maste]

On Mon, 29 Aug 2022 at 12:18, Jason A. Donenfeld <Jason@zx2c4.com> wrote:
> On Tue, Aug 23, 2022 at 12:26:21PM +0300, Michael Pro wrote:
> > Tonight after updating kernel freebsd current I got coredump with
> > wireguard enabled kernel module.
> > ...
> Thanks. Is there a __FreeBSD_version__ change that corresponds?

It is not an exact match, but was bumped to 1400066 shortly after and
should be a suitable value to check.

Re: FreeBSD current socket-src changed. Wireguard not compiling.

[Michael Pro]

FreeBSD Current (14.0)
http://ftp.freebsd.org/pub/FreeBSD/snapshots/ISO-IMAGES/14.0/
sources from iso or github - no matther
Changes to src are made by commit e7d02be19d40063783d6b8f1ff2bc4c7170fd434
Author Gleb Smirnoff <glebius@FreeBSD.org> Wed, 17 Aug 2022 21:50:32
+0300 (11:50 -0700)

ср, 31 авг. 2022 г. в 21:18, Ed Maste <emaste@freebsd.org>:
>
> On Mon, 29 Aug 2022 at 12:18, Jason A. Donenfeld <Jason@zx2c4.com> wrote:
> > On Tue, Aug 23, 2022 at 12:26:21PM +0300, Michael Pro wrote:
> > > Tonight after updating kernel freebsd current I got coredump with
> > > wireguard enabled kernel module.
> > > ...
> > Thanks. Is there a __FreeBSD_version__ change that corresponds?
>
> It is not an exact match, but was bumped to 1400066 shortly after and
> should be a suitable value to check.

Re: FreeBSD current socket-src changed. Wireguard not compiling.

[Jason A. Donenfeld]

Hi Ed,

On Wed, Aug 31, 2022 at 8:18 PM Ed Maste <emaste@freebsd.org> wrote:
>
> On Mon, 29 Aug 2022 at 12:18, Jason A. Donenfeld <Jason@zx2c4.com> wrote:
> > On Tue, Aug 23, 2022 at 12:26:21PM +0300, Michael Pro wrote:
> > > Tonight after updating kernel freebsd current I got coredump with
> > > wireguard enabled kernel module.
> > > ...
> > Thanks. Is there a __FreeBSD_version__ change that corresponds?
>
> It is not an exact match, but was bumped to 1400066 shortly after and
> should be a suitable value to check.

Thanks.

Michael - could you give this a try?
https://git.zx2c4.com/wireguard-freebsd/commit/?id=89b7292797c17449e24f5b8b08cb2412a51d2484

Jason

Re: FreeBSD current socket-src changed. Wireguard not compiling.

[Jason A. Donenfeld]

On Sun, Sep 4, 2022 at 7:07 PM Jason A. Donenfeld <Jason@zx2c4.com> wrote:
>
> Hi Ed,
>
> On Wed, Aug 31, 2022 at 8:18 PM Ed Maste <emaste@freebsd.org> wrote:
> >
> > On Mon, 29 Aug 2022 at 12:18, Jason A. Donenfeld <Jason@zx2c4.com> wrote:
> > > On Tue, Aug 23, 2022 at 12:26:21PM +0300, Michael Pro wrote:
> > > > Tonight after updating kernel freebsd current I got coredump with
> > > > wireguard enabled kernel module.
> > > > ...
> > > Thanks. Is there a __FreeBSD_version__ change that corresponds?
> >
> > It is not an exact match, but was bumped to 1400066 shortly after and
> > should be a suitable value to check.
>
> Thanks.
>
> Michael - could you give this a try?
> https://git.zx2c4.com/wireguard-freebsd/commit/?id=89b7292797c17449e24f5b8b08cb2412a51d2484

Err, that would be the wrong code copy&paste. This, I meant:
https://git.zx2c4.com/wireguard-freebsd/commit/?id=20584d1c329ed2a71893375fa11ca4c56ed9f642