Development discussion of WireGuard
 help / color / mirror / Atom feed
From: Laura Zelenku <laura.zelenku@wandera.com>
To: WireGuard mailing list <wireguard@lists.zx2c4.com>
Subject: [PATCH] Lower log level on handshake race condition
Date: Fri, 18 Feb 2022 11:08:27 +0100	[thread overview]
Message-ID: <CAA-4Yo3orPJME2kAreKn7U7yC5=u9ca3jbTZStMam8F=Qt2tOg@mail.gmail.com> (raw)

This issue is caused by "handshake initiation must be consumed first"
error. It is quite weird
because this is happening during responding on received Handshake
initiation message but probably
status of handshake is not set correctly in single thread for single peer.

Signed-off-by: Laura Zelenku <laura.zelenku@wandera.com>
---
 device/send.go | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/device/send.go b/device/send.go
index 0a7135f..0f0905a 100644
--- a/device/send.go
+++ b/device/send.go
@@ -144,7 +144,7 @@ func (peer *Peer) SendHandshakeResponse() error {

        response, err := peer.device.CreateMessageResponse(peer)
        if err != nil {
-               peer.device.log.Errorf("%v - Failed to create response
message: %v", peer, err)
+               peer.device.log.Verbosef("%v - Failed to create
response message: %v", peer, err)
                return err
        }

-- 
2.32.0 (Apple Git-132)

-- 
*IMPORTANT NOTICE*: This email, its attachments and any rights attaching 
hereto are confidential and intended exclusively for the person to whom the 
email is addressed. If you are not the intended recipient, do not read, 
copy, disclose or use the contents in any way. Wandera accepts no liability 
for any loss, damage or consequence resulting directly or indirectly from 
the use of this email and attachments.

                 reply	other threads:[~2022-02-18 10:08 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAA-4Yo3orPJME2kAreKn7U7yC5=u9ca3jbTZStMam8F=Qt2tOg@mail.gmail.com' \
    --to=laura.zelenku@wandera.com \
    --cc=wireguard@lists.zx2c4.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).