Development discussion of WireGuard
 help / color / mirror / Atom feed
From: Steffan Karger <steffan@karger.me>
To: Ludvig Strigeus <strigeus@gmail.com>
Cc: wireguard@lists.zx2c4.com
Subject: Re: Tunsafe Windows client for wireguard (not opensource yet they say
Date: Tue, 6 Mar 2018 13:32:39 +0100	[thread overview]
Message-ID: <CAA1Abx+GY1ioJ8Hnwp7Fezx6bqmukv5sw32owFcG2-zGSuhMAg@mail.gmail.com> (raw)
In-Reply-To: <CAHT-BTRX+bgN8m7V95QqnKOD8g6vp3-+h_JozG5motqS0MLiZQ@mail.gmail.com>

Hi Ludvig,

On 6 March 2018 at 02:44, Ludvig Strigeus <strigeus@gmail.com> wrote:
> Jason A. Donenfeld wrote:
>> This isn't the source code of tunsafe. This is the source code of the >
>> OpenVPN Windows tuntap kernel driver, which has been hacked up in > various
>> ways for tunsafe. That's a super scary driver, by the way.
>
> Incorrect. The driver files are not modified at all. They still
> carry OpenVPN's codesigning signature. You can see this on the
> driver install prompt:
> https://tunsafe.com/img/quickstart-driver-confirm.png
>
> I agree that the driver is scary, I think I even found some
> potential OOB memory accesses in it from a quick glance. However,
> this is the best driver the community has at this point in time,
> and even your own userspace implementations of WG use it. I'd
> be happy to improve it but then I need an expensive driver
> codesigning certificate in order to load it into the kernel.

Please report any issues you find in the tap-windows driver to
security@openvpn.net, so those can be fixed and many more people can
profit from your work.

In the same train of thought: you don't need a code signing
certificate to improve the driver, you are more than welcome to work
with the openvpn community to improve it (I expect, I don't actually
work on tap-windows myself). Just send your patches to
openvpn-devel@lists.sourceforge.net, or discuss your plans beforehand
on the list if you want confirmation that your plans are okay with the
community.  Then wait for the next OpenVPN release to get your signed
binary :)

-Steffan

  parent reply	other threads:[~2018-03-06 12:23 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-06  1:44 Ludvig Strigeus
2018-03-06  9:16 ` Jason A. Donenfeld
2018-03-06 12:32 ` Steffan Karger [this message]
  -- strict thread matches above, loose matches on Subject: below --
2018-03-05  8:26 Henrique Carrega
2018-03-05  9:19 ` Jason A. Donenfeld
2018-03-05 11:11   ` Henrique Carrega
2018-03-05 11:19   ` David Woodhouse
2018-03-05 11:25     ` Sebastian Gottschall
2018-03-05 11:33     ` Jason A. Donenfeld
2018-03-05 11:29   ` Sebastian Gottschall
2018-03-05 11:31     ` Jason A. Donenfeld
2018-03-05 11:29   ` Sebastian Gottschall

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAA1Abx+GY1ioJ8Hnwp7Fezx6bqmukv5sw32owFcG2-zGSuhMAg@mail.gmail.com \
    --to=steffan@karger.me \
    --cc=strigeus@gmail.com \
    --cc=wireguard@lists.zx2c4.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).