From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.3 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,HTML_MESSAGE,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A5418C0650F for ; Mon, 5 Aug 2019 19:14:17 +0000 (UTC) Received: from krantz.zx2c4.com (krantz.zx2c4.com [192.95.5.69]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3F2F820B1F for ; Mon, 5 Aug 2019 19:14:17 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="UuWad9jx" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3F2F820B1F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=wireguard-bounces@lists.zx2c4.com Received: from krantz.zx2c4.com (localhost [IPv6:::1]) by krantz.zx2c4.com (ZX2C4 Mail Server) with ESMTP id 45492271; Mon, 5 Aug 2019 19:14:01 +0000 (UTC) Received: from krantz.zx2c4.com (localhost [127.0.0.1]) by krantz.zx2c4.com (ZX2C4 Mail Server) with ESMTP id 07aef934 for ; Mon, 5 Aug 2019 19:13:59 +0000 (UTC) Received: from mail-ot1-x344.google.com (mail-ot1-x344.google.com [IPv6:2607:f8b0:4864:20::344]) by krantz.zx2c4.com (ZX2C4 Mail Server) with ESMTP id 80a0b7a4 for ; Mon, 5 Aug 2019 19:13:59 +0000 (UTC) Received: by mail-ot1-x344.google.com with SMTP id j11so29172756otp.10 for ; Mon, 05 Aug 2019 12:13:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=5pfKe2VJXIh4dhgLFINi3UBD/W4HO6fsTsMe0xyRCqc=; b=UuWad9jxUU5VaiWQ6GptKNnm6oXa+6jtJPK0SdftX6RDLR5K03f9xzlnLf/SHFd22B 8kqJknMPg5aEgMi02gFxPSw/6AVAUmhv9ALLlG2xH/91Nz2LrkVM1ZsGMcBYHSjCV740 agfPOmhyGHBc8jq6foLQ5sKvQo4Yeox9f9/bbZBW5q9ZPqB9eW9Pk8cNfRKpu2nq42nV 3E6/aXvc/BeVGrTfA/JewRSO6GxXRwk5ccIVxcS+fMR+J5PD15uGfX7d1W+UbrihEfDf NlyLy+8GVwl9m1enGkNRB86uepQltwYZI20QjM8dzp+vK1sfq4aJBUh0DM1nlRwRFtlw Nt2g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=5pfKe2VJXIh4dhgLFINi3UBD/W4HO6fsTsMe0xyRCqc=; b=iez+gP6esZCVMpyC5JfPQKBkpVo8LxIdWsSCw7GdzW/kAx6CCAidqDt1DNiULiESFe EFhY9R197d5qn5OykU0cZeDYol3PgjbMo8MBR3eCX2vM2hwDjgQhdgBtMTze0vHzgbhS ETj4K8EyxlUnyoQstVQU7oF1RR+WcE+zR4WqWAPjr0eOty5Bj1loVmudpj69eqTGG7+f /fL+PVgF9IaItYfx9c7JQvEUWdePt30AX1BTI54xvI5fPi1RmNXJebA2/qG+jDSK2xTJ aBUS2cu9zQUzGGuU/lu1ESfJUoaZhLcxFwilfPRfHbwo02OMh6poheLTCnUxLLqqy6KL dG2w== X-Gm-Message-State: APjAAAX/ebYRfAdve55kZHwem9n++gT3XlvNNS7iOs2/bKtALzZbmQKq w8P7Cq45lj57GwEmDpZr3H4vAAu40fpEU792HlWYK+45 X-Google-Smtp-Source: APXvYqzi3m04MpMLcNBiSbv5hmX+vBcx5im7WCBxkqd8d2RKBRwvXVTZpSIMNu5fgoO6w3u8wgGh0iUaQN7ngJk5DLI= X-Received: by 2002:a6b:2cc7:: with SMTP id s190mr5634994ios.164.1565032438877; Mon, 05 Aug 2019 12:13:58 -0700 (PDT) MIME-Version: 1.0 References: <20190720122016.57765-1-ankur@lipidity.com> In-Reply-To: From: Janne Johansson Date: Mon, 5 Aug 2019 21:13:45 +0200 Message-ID: Subject: Re: [PATCH] wg-quick: Fix alternate routing table syntax on OpenBSD To: "Jason A. Donenfeld" Cc: WireGuard mailing list X-BeenThere: wireguard@lists.zx2c4.com X-Mailman-Version: 2.1.15 Precedence: list List-Id: Development discussion of WireGuard List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============5393451992283092174==" Errors-To: wireguard-bounces@lists.zx2c4.com Sender: "WireGuard" --===============5393451992283092174== Content-Type: multipart/alternative; boundary="00000000000094d2eb058f638201" --00000000000094d2eb058f638201 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable According to "man route" on openbsd, the -T is how its supposed to be run: The other commands relating to adding, changing, or deleting routes have the syntax: *route* [*-dnqtv*] [*-T* rtable] *add* [modifiers] destination gateway The manpage for "route" doesn't even contain "rdomain" so I would assume Ankur is correct in that diff. Den m=C3=A5n 5 aug. 2019 kl 20:47 skrev Jason A. Donenfeld : > Hi Ankur, > > Thanks for this. Could you provide your Signed-off-by line? Also, why > is this required? Is this a recent change in syntax? A new syntax? Was > the syntax always wrong? What's the deal? > > Thanks, > Jason > _______________________________________________ > WireGuard mailing list > WireGuard@lists.zx2c4.com > https://lists.zx2c4.com/mailman/listinfo/wireguard > --=20 May the most significant bit of your life be positive. --00000000000094d2eb058f638201 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
According to "man route" on ope= nbsd, the -T is how its supposed to be run:

=C2=A0 =C2=A0 =C2=A0The other commands relating to addi= ng, changing, or deleting routes have

=C2=A0=C2=A0 =C2=A0 the syntax:


=C2=A0=C2=A0 =C2=A0 route [-dnqtv] [-T= rtable] add = [modifiers] destination gateway



The manpage for "route" doesn't even contain "r= domain" so I would assume Ankur is correct in that diff.


Den m=C3=A5n 5 aug. 2019 kl 20:47 sk= rev Jason A. Donenfeld <Jason@zx2c4.c= om>:
Hi A= nkur,

Thanks for this. Could you provide your Signed-off-by line? Also, why
is this required? Is this a recent change in syntax? A new syntax? Was
the syntax always wrong? What's the deal?

Thanks,
Jason
_______________________________________________
WireGuard mailing list
WireGuard@li= sts.zx2c4.com
https://lists.zx2c4.com/mailman/listinfo/wireguard=


--
May the most significant bit of your life be pos= itive.
--00000000000094d2eb058f638201-- --===============5393451992283092174== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ WireGuard mailing list WireGuard@lists.zx2c4.com https://lists.zx2c4.com/mailman/listinfo/wireguard --===============5393451992283092174==--