Re: [PATCH wireguard-apple] Update SPDX-License-Identifier tags from GPL-2.0 to MIT

[Adam Stiles <ajstiles@gmail.com>]

Hi Jonathan,

Thanks for looking at the patch. In retrospect, I should have asked
about this before I submitted it. I wasn't intending a re-license.
Rather, I assumed those SPDX identifiers were missed when repo was
converted from GPL to MIT a couple of years ago. Apologies,

Adam


On Sun, Dec 13, 2020 at 3:42 PM Jonathan Neuschäfer
<j.neuschaefer@gmx.net> wrote:
>
> Hi,
>
> a little drive-by review, since I happened to see the patch.
> In case I misunderstood something, I apologise in advance.
>
> On Thu, Dec 10, 2020 at 03:54:12PM -0800, Adam Stiles wrote:
> > Signed-off-by: Adam Stiles <ajstiles@gmail.com>
> > ---
> >  Sources/WireGuardApp/UI/macOS/View/highlighter.c | 2 +-
> >  Sources/WireGuardApp/UI/macOS/View/highlighter.h | 2 +-
> >  Sources/WireGuardKitC/key.c                      | 2 +-
> >  Sources/WireGuardKitC/key.h                      | 2 +-
> >  Sources/WireGuardKitC/x25519.c                   | 2 +-
> >  Sources/WireGuardKitGo/Makefile                  | 2 +-
> >  Sources/WireGuardKitGo/wireguard.h               | 2 +-
> >  7 files changed, 7 insertions(+), 7 deletions(-)
> >
> > diff --git a/Sources/WireGuardApp/UI/macOS/View/highlighter.c b/Sources/WireGuardApp/UI/macOS/View/highlighter.c
> > index e0d4e04..55fabfd 100644
> > --- a/Sources/WireGuardApp/UI/macOS/View/highlighter.c
> > +++ b/Sources/WireGuardApp/UI/macOS/View/highlighter.c
> > @@ -1,4 +1,4 @@
> > -// SPDX-License-Identifier: GPL-2.0
> > +// SPDX-License-Identifier: MIT
>
> AFAIUI, such a change expresses a relicensing of the code, and it should
> (IMHO) be made clear in the commit message that this is the case.
>
> All authors of the code must agree to a relicensing. It would be nice
> to see the list of authors in the commit message, along with a
> confirmation that all agreed to relicense the code to MIT.
>
> > -/* SPDX-License-Identifier: GPL-2.0+
> > +/* SPDX-License-Identifier: MIT+
>
> I think MIT+ is an editing error. It's not on the official SPDX license
> identifier list, in any case.
>
>
> Best regards,
> Jonathan Neuschäfer