Development discussion of WireGuard
 help / color / mirror / Atom feed
From: Andriy Perev Ortkin <irherder@gmail.com>
To: wireguard@lists.zx2c4.com
Subject: commit 99895f27f3d63d2e92a5c1c411205ae70f2a5ca breaks build on arm64
Date: Sat, 15 Jun 2019 19:10:34 +0300	[thread overview]
Message-ID: <CABwq4PiyPwjPL+RPVcWZYy66j4gaVRc3OHEA6Aqm_SbL=9VFAQ@mail.gmail.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 700 bytes --]

commit https://git.zx2c4.com/WireGuard/commit/?id=799895f27f3d63d2e92a5c1c411205ae70f2a5ca
breaks out of tree module build on arm64 , kernel 5.1.10
strangely when building x86_64 everything is fine

  CC [M]  /home/asavah/kross/src/WireGuard/src/main.o
In file included from /home/asavah/kross/src/WireGuard/src/compat/compat.h:824,
                 from <command-line>:
./include/linux/timekeeping.h:67:8: error: unknown type name ‘ktime_t’
   67 | extern ktime_t ktime_get(void);
      |        ^~~~~~~

The following patch fixes the issue, however I have no idea why x86_64
builds fine and arm64 does not,
neither I'm sure that the patch is right, it fixed the issue for me tho.

[-- Attachment #2: 001-ktime.patch --]
[-- Type: application/octet-stream, Size: 427 bytes --]

diff --git a/src/compat/compat.h b/src/compat/compat.h
index 614f458..5ba9b67 100644
--- a/src/compat/compat.h
+++ b/src/compat/compat.h
@@ -821,6 +821,7 @@ static inline void skb_mark_not_on_list(struct sk_buff *skb)
 #if LINUX_VERSION_CODE < KERNEL_VERSION(3, 17, 0)
 #include <linux/hrtimer.h>
 #else
+#include <linux/ktime.h>
 #include <linux/timekeeping.h>
 #endif
 static inline s64 __our_ktime_get_coarse_boottime(void)

[-- Attachment #3: Type: text/plain, Size: 148 bytes --]

_______________________________________________
WireGuard mailing list
WireGuard@lists.zx2c4.com
https://lists.zx2c4.com/mailman/listinfo/wireguard

             reply	other threads:[~2019-06-18 15:13 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-15 16:10 Andriy Perev Ortkin [this message]
2019-06-18 16:24 ` Jason A. Donenfeld
2019-06-18 19:03   ` Jason A. Donenfeld

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CABwq4PiyPwjPL+RPVcWZYy66j4gaVRc3OHEA6Aqm_SbL=9VFAQ@mail.gmail.com' \
    --to=irherder@gmail.com \
    --cc=wireguard@lists.zx2c4.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).