From: Jacob Lifshay <firstname.lastname@example.org> To: "Jason A. Donenfeld" <Jason@zx2c4.com> Cc: email@example.com Subject: Re: why not use ktime_get_clocktai_ts64 Date: Sat, 18 Jun 2022 23:16:46 -0700 [thread overview] Message-ID: <CAC2bXD7g8QsFi_Cw5rpiPRBz_vEPa4SJQF7f7COyfMJq6kVqfirstname.lastname@example.org> (raw) In-Reply-To: <Yqxr57xeYHYI3F22@zx2c4.com> On Fri, Jun 17, 2022, 04:56 Jason A. Donenfeld <Jason@zx2c4.com> wrote: > > Hi Jacob, > > On Wed, Jun 15, 2022 at 06:48:08PM -0700, Jacob Lifshay wrote: > > I was reading in noise.c and noticed you use ktime_get_real_ts64 and > > do manual adjustments (the current code is broken if/when there's > > another leap second) rather than using ktime_get_clocktai_ts64 which > > already handles compensation for leap seconds. > > > > https://git.zx2c4.com/wireguard-linux/tree/drivers/net/wireguard/noise.c?id=7fae4596a269d2f9a6a7d1a8695c3a68ab34f7be#n501 > > > > Is there a reason for that? > > Not really I guess. The only requirement, though, is that the timestamps > are monotonic with respect to the particular localprivate-remotepublic > pairing of peers. So I'm not sure it matters? ok. Apparently linux's TAI clock offset is often not set on linux systems, so that's a good reason not to use it. Do note that 10s is the wrong offset, the correct value is 37s iirc. see also (related issue on tai64 crate -- also uses the wrong offset): https://github.com/RustCrypto/formats/issues/675 Jacob
prev parent reply other threads:[~2022-06-19 6:17 UTC|newest] Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-06-16 1:48 Jacob Lifshay 2022-06-17 11:56 ` Jason A. Donenfeld 2022-06-19 6:16 ` Jacob Lifshay [this message]
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='CAC2bXD7g8QsFi_Cw5rpiPRBz_vEPa4SJQF7f7COyfMJq6kVqemail@example.com' \ --firstname.lastname@example.org \ --cc=Jason@zx2c4.com \ --email@example.com \ --subject='Re: why not use ktime_get_clocktai_ts64' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).