Development discussion of WireGuard
 help / color / mirror / Atom feed
From: Garrit Franke <garritfranke@gmail.com>
To: Eric Light <eric@ericlight.com>
Cc: "Jason A. Donenfeld" <Jason@zx2c4.com>,
	WireGuard mailing list <wireguard@lists.zx2c4.com>
Subject: Re: [PATCH] wg-quick: add restart command
Date: Wed, 17 Jun 2020 14:25:51 +0200	[thread overview]
Message-ID: <CAD16O85k90LSSzno1pQpOXGKTzfEx=uKGbaduWmmL5WMQ2RwSQ@mail.gmail.com> (raw)
In-Reply-To: <bbb39589-9b55-49fc-9723-8086909e0bcf@www.fastmail.com>

Thanks for your comments!
I really like the systemctl reload approach. My main intention with
this patchset was to add this feature to wg-quicks arsenal because (at
least for me) it's the most obvious approach. I mainly use `wg-quick
down wg0 && wg0 up wg0`, I think you guys see where I'm coming from.

I haven't dealt with systemd units yet, but I can certainly look into
it and submit a corresponding patch soon.

Am Mi., 17. Juni 2020 um 10:32 Uhr schrieb Eric Light <eric@ericlight.com>:
>
> Oh hey that sounds like a great way to do it.  Seems like it'd be simpler than this patch set as well, which is always good.
>
> E
>
> --------------------------------------------
> Q: Why is this email five sentences or less?
> A: http://five.sentenc.es
>
> On Wed, 17 Jun 2020, at 20:19, Jason A. Donenfeld wrote:
> > On Wed, Jun 17, 2020 at 2:17 AM Eric Light <eric@ericlight.com> wrote:
> > >
> > > As a purely Debian user, the 'service x restart' pattern is far more memorable than the syncconf method.  I know personal preference isn't a great reason to add a knob, but Garrit's method is probably going to be much more familiar to many users.
> >
> > For users who want service management patterns like that, it'd
> > certainly be possible to map the wg-quick strip stuff to `systemctl
> > reload wg-quick@wg0.service`, for that purpose. Maybe that's something
> > we should consider?
> >

  reply	other threads:[~2020-06-18 19:55 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-28 18:45 Garrit Franke
2020-05-28 18:45 ` [PATCH 1/6] wg-quick: linux: " Garrit Franke
2020-05-28 18:45 ` [PATCH 2/6] wg-quick: add restart man page Garrit Franke
2020-05-28 18:45 ` [PATCH 3/6] wg-quick: freebsd: add restart command Garrit Franke
2020-05-28 18:45 ` [PATCH 4/6] wg-quick: linux: add notice to " Garrit Franke
2020-05-28 18:45 ` [PATCH 5/6] wg-quick: openbsd: add " Garrit Franke
2020-05-28 18:45 ` [PATCH 6/6] wg-quick: darwin: " Garrit Franke
2020-06-17  7:47 ` [PATCH] wg-quick: " Jason A. Donenfeld
2020-06-17  8:16   ` Eric Light
2020-06-17  8:18     ` Eric Light
2020-06-17  8:19     ` Jason A. Donenfeld
2020-06-17  8:30       ` Eric Light
2020-06-17 12:25         ` Garrit Franke [this message]
2020-06-20  7:02       ` Tore Anderson
     [not found]         ` <CAD16O87AEvaP3Y0TKPvrps=MVdzw-34+=rBOmF_c7s=Eu9kSQw@mail.gmail.com>
2020-06-21 10:36           ` Tore Anderson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAD16O85k90LSSzno1pQpOXGKTzfEx=uKGbaduWmmL5WMQ2RwSQ@mail.gmail.com' \
    --to=garritfranke@gmail.com \
    --cc=Jason@zx2c4.com \
    --cc=eric@ericlight.com \
    --cc=wireguard@lists.zx2c4.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).