From: Patrick Glandien <patrick@synix.io>
To: "wireguard lists.zx2c4.com" <wireguard@lists.zx2c4.com>
Subject: Re: wireguard-go relative imports
Date: Tue, 20 Feb 2018 02:10:14 -0700 [thread overview]
Message-ID: <CADy+xPkZTf+p9eEQiOSXsAhg39yPP0b57pw+kprVctVQoV_=9g@mail.gmail.com> (raw)
(Pardon for previously sending an HTML response)
Dominik,
While relative imports are discouraged in Go, I could see it making it
sense in the context of highly sensitive code such as wireguard.
The go dependency system, including `go get`, don't guarantee as to
whether the code is authentic (e.g. signed).
This is a problem to the entire ecosystem of the language as recently
witnessed when someone replaced a commonly used go package hosted on
github after the user deleted his account: <https://redd.it/7vv9zz>.
I have not looked into the wireguard-go code very much, but if it's
merely meant to be a wireguard implementation in Go (not to be used as
a library) - then either relative import paths or top-level paths in
an isolated go workspace would be sensible and should not be changed
to the usual canonical URL imports.
=E2=80=94 Patrick Glandien
next reply other threads:[~2018-02-20 9:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-20 9:10 Patrick Glandien [this message]
[not found] <mailman.180.1519108159.2201.wireguard@lists.zx2c4.com>
2018-02-20 9:04 ` Patrick Glandien
-- strict thread matches above, loose matches on Subject: below --
2018-02-19 12:04 Dominik Süß
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CADy+xPkZTf+p9eEQiOSXsAhg39yPP0b57pw+kprVctVQoV_=9g@mail.gmail.com' \
--to=patrick@synix.io \
--cc=wireguard@lists.zx2c4.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).