From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.3 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,HTML_MESSAGE,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9246BC2BA83 for ; Sun, 16 Feb 2020 15:55:09 +0000 (UTC) Received: from krantz.zx2c4.com (krantz.zx2c4.com [192.95.5.69]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 33A3C20729 for ; Sun, 16 Feb 2020 15:55:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="fP+v6gHJ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 33A3C20729 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=wireguard-bounces@lists.zx2c4.com Received: from krantz.zx2c4.com (localhost [IPv6:::1]) by krantz.zx2c4.com (ZX2C4 Mail Server) with ESMTP id ff39bc0e; Sun, 16 Feb 2020 15:52:04 +0000 (UTC) Received: from krantz.zx2c4.com (localhost [127.0.0.1]) by krantz.zx2c4.com (ZX2C4 Mail Server) with ESMTP id 43133d07 for ; Sun, 16 Feb 2020 15:52:01 +0000 (UTC) Received: from mail-ed1-x544.google.com (mail-ed1-x544.google.com [IPv6:2a00:1450:4864:20::544]) by krantz.zx2c4.com (ZX2C4 Mail Server) with ESMTP id ae4e9325 for ; Sun, 16 Feb 2020 15:52:01 +0000 (UTC) Received: by mail-ed1-x544.google.com with SMTP id m13so17531258edb.6 for ; Sun, 16 Feb 2020 07:54:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=eg4HvmfWY0VoOWdtwbWc0Gbh3fDgGwCgI6LnvF7zUDs=; b=fP+v6gHJ58RqMdoeIGta0hUk74/GdyXXNRy8fz8ZCxI8ofUV9p1rfx31wek8bSmuZo Yga+uwDYrE/5aRi7MohLUbU4BrC1wamRjAksj1O9diEuvKcsRs5U9DlmqiX0o67zVB36 CK84G9ZtFca7Rr+KLhw+KZOKbDVHhFXsHaxEht/vj28/LiXxf0NT+4y1w+M5nzDqruRy fxxvupY0owh1+hFpYU+EqV78I5TZpzAXJypCB1TrKEdZYwz/3dH37qJIW7le1A1ul/1z u4cCUrahs9fJLwHOiaScb+mkJIOcsk8JG7XtL7Dle8WPXi4yPs7CdOdb8UxrDFQONEKM 63oA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=eg4HvmfWY0VoOWdtwbWc0Gbh3fDgGwCgI6LnvF7zUDs=; b=feRUDtFPtGdvtU8xJ4V8TugiB7mFv5kZVvn1vJk8IuU+0aoIDL4jz5fNVSfZkfctgb v5a+PochE2u398Pb2a9DZ2mw6OEwlxFgH2Kx/TmkthPDpEzYir3EcpdknZzS/qy5pUru 6eGoz+eukceg+V07jDkq7ITEmkt6YJ12EoydZNXwz84pR6l4xdKAwH5XLkyWEG0Z6qaW 4HVamkFLthgmMRucn0G6pTLSRSjF0K65guLEXPohE0G6sJ1JTTFZPpsHmXuVf5wcdf8V H+1l6tH68vB8CUeDYmdusjk6sX3EP88K295e8WjHKruhuoaGj/Zfrn52BFK7Aq/n4AqT uNDA== X-Gm-Message-State: APjAAAWHHteYKgm8x+Hxym3SMfFwBmPHhpLYTn1FZe6sp5mDRVFvKSlk ZhNC86D/Rey4jUVrcAfMGbYUIPsXuwQd2oeMEYmmOa+qfRU= X-Google-Smtp-Source: APXvYqy1/zGlywEwh/j4D0tmxnl0cih0/WLslLT1ue+ML+eSD+cgBiZU7MA8/5Aoz234n1qEEHXDzeMma6wiTDNmsbw= X-Received: by 2002:a17:906:b819:: with SMTP id dv25mr11707529ejb.211.1581868463018; Sun, 16 Feb 2020 07:54:23 -0800 (PST) MIME-Version: 1.0 References: <20200209173058.11647-1-sebcbi1@gmail.com> In-Reply-To: From: Sebastien LEBEAU Date: Sun, 16 Feb 2020 17:54:12 +0200 Message-ID: Subject: Re: [PATCH] Change "Deselect All" to "Toggle All" in Excluded apps settings To: "Jason A. Donenfeld" , wireguard@lists.zx2c4.com X-BeenThere: wireguard@lists.zx2c4.com X-Mailman-Version: 2.1.15 Precedence: list List-Id: Development discussion of WireGuard List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============2543260012950115362==" Errors-To: wireguard-bounces@lists.zx2c4.com Sender: "WireGuard" --===============2543260012950115362== Content-Type: multipart/alternative; boundary="000000000000d1d78a059eb373eb" --000000000000d1d78a059eb373eb Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Signed-off-by: S=C3=A9bastien LEBEAU --- .../com/wireguard/android/fragment/AppListDialogFragment.java | 4 ++-- app/src/main/res/values-it/strings.xml | 2 +- app/src/main/res/values-ru/strings.xml | 2 +- app/src/main/res/values/strings.xml | 2 +- 4 files changed, 5 insertions(+), 5 deletions(-) diff --git a/app/src/main/java/com/wireguard/android/fragment/AppListDialogFragment.ja= va b/app/src/main/java/com/wireguard/android/fragment/AppListDialogFragment.ja= va index 67059c7..c513d47 100644 --- a/app/src/main/java/com/wireguard/android/fragment/AppListDialogFragment.ja= va +++ b/app/src/main/java/com/wireguard/android/fragment/AppListDialogFragment.ja= va @@ -98,7 +98,7 @@ public class AppListDialogFragment extends DialogFragment { alertDialogBuilder.setPositiveButton(R.string.set_exclusions, (dialog, which) -> setExclusionsAndDismiss()); alertDialogBuilder.setNegativeButton(R.string.cancel, (dialog, which) -> dialog.dismiss()); - alertDialogBuilder.setNeutralButton(R.string.deselect_all, (dialog, which) -> { + alertDialogBuilder.setNeutralButton(R.string.toggle_all, (dialog, which) -> { }); binding.setFragment(this); @@ -109,7 +109,7 @@ public class AppListDialogFragment extends DialogFragment { final AlertDialog dialog =3D alertDialogBuilder.create(); dialog.setOnShowListener(d -> dialog.getButton(DialogInterface.BUTTON_NEUTRAL).setOnClickListener(view -> { for (final ApplicationData app : appData) - app.setExcludedFromTunnel(false); + app.setExcludedFromTunnel(!app.isExcludedFromTunnel()); })); return dialog; } diff --git a/app/src/main/res/values-it/strings.xml b/app/src/main/res/values-it/strings.xml index 2aba5f8..b37d792 100644 --- a/app/src/main/res/values-it/strings.xml +++ b/app/src/main/res/values-it/strings.xml @@ -66,7 +66,7 @@ Stai usando il tema scuro (notte) Usa tema scuro Elimina - Deseleziona tutto + Inverti tutto Server DNS Modifica Endpoint diff --git a/app/src/main/res/values-ru/strings.xml b/app/src/main/res/values-ru/strings.xml index 2f2c03b..00b96fb 100644 --- a/app/src/main/res/values-ru/strings.xml +++ b/app/src/main/res/values-ru/strings.xml @@ -66,7 +66,7 @@ =D0=92 =D0=B4=D0=B0=D0=BD=D0=BD= =D1=8B=D0=B9 =D0=BC=D0=BE=D0=BC=D0=B5=D0=BD=D1=82 =D0=B8=D1=81=D0=BF=D0=BE= =D0=BB=D1=8C=D0=B7=D1=83=D0=B5=D1=82=D1=81=D1=8F =D1=82=D0=B5=D0=BC=D0=BD=D0=B0=D1=8F (=D0=BD=D0=BE=D1=87=D0=BD=D0=B0=D1=8F)= =D1=82=D0=B5=D0=BC=D0=B0 =D0=98=D1=81=D0=BF=D0=BE=D0=BB=D1=8C= =D0=B7=D0=BE=D0=B2=D0=B0=D1=82=D1=8C =D1=82=D0=B5=D0=BC=D0=BD=D1=83=D1=8E = =D1=82=D0=B5=D0=BC=D1=83 =D0=A3=D0=B4=D0=B0=D0=BB=D0=B8=D1=82=D1=8C - =D0=A1=D0=BD=D1=8F=D1=82=D1=8C =D0=B2=D1= =8B=D0=B4=D0=B5=D0=BB=D0=B5=D0=BD=D0=BD=D0=BE=D0=B5 + =D0=98=D0=BD=D0=B2=D0=B5=D1=80=D1=82=D0=B8= =D1=80=D0=BE=D0=B2=D0=B0=D1=82=D1=8C =D0=B2=D1=81=D0=B5 DNS-=D1=81=D0=B5=D1=80=D0=B2=D0=B5=D1=80= =D1=8B =D0=A0=D0=B5=D0=B4=D0=B0=D0=BA=D1=82=D0=B8=D1=80= =D0=BE=D0=B2=D0=B0=D1=82=D1=8C =D0=9A=D0=BE=D0=BD=D0=B5=D1=87=D0=BD=D0=B0= =D1=8F =D1=82=D0=BE=D1=87=D0=BA=D0=B0 diff --git a/app/src/main/res/values/strings.xml b/app/src/main/res/values/strings.xml index 336cd4e..89a32c0 100644 --- a/app/src/main/res/values/strings.xml +++ b/app/src/main/res/values/strings.xml @@ -66,7 +66,7 @@ Currently using dark (night) theme Use dark theme Delete - Deselect All + Toggle All DNS servers Edit Endpoint --=20 2.25.0 --000000000000d1d78a059eb373eb Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Signed-off-by: S=C3=A9bastien LEBEAU = <sebcbi1@gmail.com>
---=C2=A0.../com/wireguard/android/fragment/AppListDialogFragment.java | 4 += +--
=C2=A0app/src/main/res/values-it/strings.xml =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0| 2 +-
=C2= =A0app/src/main/res/values-ru/strings.xml =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0| 2 +-
=C2=A0app/src= /main/res/values/strings.xml =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 | 2 +-
=C2=A04 files chang= ed, 5 insertions(+), 5 deletions(-)

diff --git a/app/src/main/java/c= om/wireguard/android/fragment/AppListDialogFragment.java b/app/src/main/jav= a/com/wireguard/android/fragment/AppListDialogFragment.java
index 67059c= 7..c513d47 100644
--- a/app/src/main/java/com/wireguard/android/fragment= /AppListDialogFragment.java
+++ b/app/src/main/java/com/wireguard/androi= d/fragment/AppListDialogFragment.java
@@ -98,7 +98,7 @@ public class App= ListDialogFragment extends DialogFragment {
=C2=A0
=C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0alertDialogBuilder.setPositiveButton(R.string.set_exclusio= ns, (dialog, which) -> setExclusionsAndDismiss());
=C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0alertDialogBuilder.setNegativeButton(R.string.cancel, (dia= log, which) -> dialog.dismiss());
- =C2=A0 =C2=A0 =C2=A0 =C2=A0alertD= ialogBuilder.setNeutralButton(R.string.deselect_all, (dialog, which) -> = {
+ =C2=A0 =C2=A0 =C2=A0 =C2=A0alertDialogBuilder.setNeutralButton(R.str= ing.toggle_all, (dialog, which) -> {
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0});
=C2=A0
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0binding.setFragment(t= his);
@@ -109,7 +109,7 @@ public class AppListDialogFragment extends Dia= logFragment {
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0final AlertDialog dialog= =3D alertDialogBuilder.create();
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0dial= og.setOnShowListener(d -> dialog.getButton(DialogInterface.BUTTON_NEUTRA= L).setOnClickListener(view -> {
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0for (final ApplicationData app : appData)
- =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0app.setExcludedFromTunnel(false);<= br>+ =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0app.setExcluded= FromTunnel(!app.isExcludedFromTunnel());
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0}));
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0return dialog;
=C2=A0 =C2= =A0 =C2=A0}
diff --git a/app/src/main/res/values-it/strings.xml b/app/sr= c/main/res/values-it/strings.xml
index 2aba5f8..b37d792 100644
--- a/= app/src/main/res/values-it/strings.xml
+++ b/app/src/main/res/values-it/= strings.xml
@@ -66,7 +66,7 @@
=C2=A0 =C2=A0 =C2=A0<string name=3D&= quot;dark_theme_summary_on">Stai usando il tema scuro (notte)</s= tring>
=C2=A0 =C2=A0 =C2=A0<string name=3D"dark_theme_title&q= uot;>Usa tema scuro</string>
=C2=A0 =C2=A0 =C2=A0<string nam= e=3D"delete">Elimina</string>
- =C2=A0 =C2=A0<stri= ng name=3D"deselect_all">Deseleziona tutto</string>
+= =C2=A0 =C2=A0<string name=3D"toggle_all">Inverti tutto<= /string>
=C2=A0 =C2=A0 =C2=A0<string name=3D"dns_servers"= ;>Server DNS</string>
=C2=A0 =C2=A0 =C2=A0<string name=3D&qu= ot;edit">Modifica</string>
=C2=A0 =C2=A0 =C2=A0<string = name=3D"endpoint">Endpoint</string>
diff --git a/app/= src/main/res/values-ru/strings.xml b/app/src/main/res/values-ru/strings.xml=
index 2f2c03b..00b96fb 100644
--- a/app/src/main/res/values-ru/strin= gs.xml
+++ b/app/src/main/res/values-ru/strings.xml
@@ -66,7 +66,7 @@=
=C2=A0 =C2=A0 =C2=A0<string name=3D"dark_theme_summary_on"= >=D0=92 =D0=B4=D0=B0=D0=BD=D0=BD=D1=8B=D0=B9 =D0=BC=D0=BE=D0=BC=D0=B5=D0= =BD=D1=82 =D0=B8=D1=81=D0=BF=D0=BE=D0=BB=D1=8C=D0=B7=D1=83=D0=B5=D1=82=D1= =81=D1=8F =D1=82=D0=B5=D0=BC=D0=BD=D0=B0=D1=8F (=D0=BD=D0=BE=D1=87=D0=BD=D0= =B0=D1=8F) =D1=82=D0=B5=D0=BC=D0=B0</string>
=C2=A0 =C2=A0 =C2=A0&= lt;string name=3D"dark_theme_title">=D0=98=D1=81=D0=BF=D0=BE= =D0=BB=D1=8C=D0=B7=D0=BE=D0=B2=D0=B0=D1=82=D1=8C =D1=82=D0=B5=D0=BC=D0=BD= =D1=83=D1=8E =D1=82=D0=B5=D0=BC=D1=83</string>
=C2=A0 =C2=A0 =C2= =A0<string name=3D"delete">=D0=A3=D0=B4=D0=B0=D0=BB=D0=B8= =D1=82=D1=8C</string>
- =C2=A0 =C2=A0<string name=3D"desel= ect_all">=D0=A1=D0=BD=D1=8F=D1=82=D1=8C =D0=B2=D1=8B=D0=B4=D0=B5=D0= =BB=D0=B5=D0=BD=D0=BD=D0=BE=D0=B5</string>
+ =C2=A0 =C2=A0<stri= ng name=3D"toggle_all">=D0=98=D0=BD=D0=B2=D0=B5=D1=80=D1=82=D0= =B8=D1=80=D0=BE=D0=B2=D0=B0=D1=82=D1=8C =D0=B2=D1=81=D0=B5</string>=C2=A0 =C2=A0 =C2=A0<string name=3D"dns_servers">DNS-=D1= =81=D0=B5=D1=80=D0=B2=D0=B5=D1=80=D1=8B</string>
=C2=A0 =C2=A0 =C2= =A0<string name=3D"edit">=D0=A0=D0=B5=D0=B4=D0=B0=D0=BA=D1= =82=D0=B8=D1=80=D0=BE=D0=B2=D0=B0=D1=82=D1=8C</string>
=C2=A0 =C2= =A0 =C2=A0<string name=3D"endpoint">=D0=9A=D0=BE=D0=BD=D0= =B5=D1=87=D0=BD=D0=B0=D1=8F =D1=82=D0=BE=D1=87=D0=BA=D0=B0</string>diff --git a/app/src/main/res/values/strings.xml b/app/src/main/res/value= s/strings.xml
index 336cd4e..89a32c0 100644
--- a/app/src/main/res/va= lues/strings.xml
+++ b/app/src/main/res/values/strings.xml
@@ -66,7 += 66,7 @@
=C2=A0 =C2=A0 =C2=A0<string name=3D"dark_theme_summary_o= n">Currently using dark (night) theme</string>
=C2=A0 =C2= =A0 =C2=A0<string name=3D"dark_theme_title">Use dark theme&= lt;/string>
=C2=A0 =C2=A0 =C2=A0<string name=3D"delete"&= gt;Delete</string>
- =C2=A0 =C2=A0<string name=3D"deselect= _all">Deselect All</string>
+ =C2=A0 =C2=A0<string name= =3D"toggle_all">Toggle All</string>
=C2=A0 =C2=A0 =C2= =A0<string name=3D"dns_servers">DNS servers</string><= br>=C2=A0 =C2=A0 =C2=A0<string name=3D"edit">Edit</strin= g>
=C2=A0 =C2=A0 =C2=A0<string name=3D"endpoint">Endp= oint</string>
--
2.25.0



--000000000000d1d78a059eb373eb-- --===============2543260012950115362== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ WireGuard mailing list WireGuard@lists.zx2c4.com https://lists.zx2c4.com/mailman/listinfo/wireguard --===============2543260012950115362==--