Development discussion of WireGuard
 help / color / mirror / Atom feed
From: Alexis gg <alexisgandroid@gmail.com>
To: wireguard@lists.zx2c4.com
Subject: reresolve-dns: use $EPOCHSECONDS instead of $(date +%s)
Date: Sat, 12 Feb 2022 11:20:39 +0900	[thread overview]
Message-ID: <CAFwG9-ZTkzZxp+ORVaGM0fHezZ51_ffVROz1Z0Ug+hz=thLzPQ@mail.gmail.com> (raw)

This commit breaks everything on older OSes (esp. Centos 7):
https://git.zx2c4.com/wireguard-tools/commit/?id=1fd95708391088742c139010cc6b821add941dec

There is no check on the bash's version, the built-in variable
$EPOCHSECONDS is available only from bash 5.
https://lists.gnu.org/archive/html/info-gnu/2019-01/msg00010.html

This isn't an improvement, $(date +%s) is stable from much older
versions and will stay stable in future bash versions.

                 reply	other threads:[~2022-02-14 13:55 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAFwG9-ZTkzZxp+ORVaGM0fHezZ51_ffVROz1Z0Ug+hz=thLzPQ@mail.gmail.com' \
    --to=alexisgandroid@gmail.com \
    --cc=wireguard@lists.zx2c4.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).