Development discussion of WireGuard
 help / color / mirror / Atom feed
From: "Jason A. Donenfeld" <Jason@zx2c4.com>
To: Michal Murin <michal.murin@jamf.com>
Cc: WireGuard mailing list <wireguard@lists.zx2c4.com>
Subject: Re: [PATCH] Fixed the failing BadConfigExceptionTest unit test
Date: Wed, 26 Jan 2022 19:25:44 +0100	[thread overview]
Message-ID: <CAHmME9oQ_SiXW-DG4HAm0k0GH17m0210U1Rb6Syuief98+w4kQ@mail.gmail.com> (raw)
In-Reply-To: <20220119082857.64215-1-michal.murin@jamf.com>

On Tue, Jan 25, 2022 at 5:12 PM Michal Murin <michal.murin@jamf.com> wrote:
> Also removed the `getParsingClass()` condition from the `parseDnsServers()` method as the condition can be never met - the `InetAddresses.parse(dnsServer)` method always throws the `ParseException` with the `parsingClass` set to `InetAddress.class`.

Until one day it doesn't, and then we have to remember this subtle
behavior. On the contrary, what's there now means that the code is
correct regardless of changes.

> -                        if (e.getParsingClass() != InetAddress.class || !InetAddresses.isHostname(dnsServer))
> +                        if (!InetAddresses.isHostname(dnsServer))

Please drop this snippet from v2.

As Harsh said, we need your sign off line. It would also be
appreciated if you'd wrap your commit message and adjust your commit
subject to match what the project uses conventionally.

Thanks,
Jason

      parent reply	other threads:[~2022-01-26 18:28 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-19  8:28 Michal Murin
2022-01-26 15:02 ` Harsh Shandilya
2022-01-26 18:25 ` Jason A. Donenfeld [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAHmME9oQ_SiXW-DG4HAm0k0GH17m0210U1Rb6Syuief98+w4kQ@mail.gmail.com \
    --to=jason@zx2c4.com \
    --cc=michal.murin@jamf.com \
    --cc=wireguard@lists.zx2c4.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).