Development discussion of WireGuard
 help / color / mirror / Atom feed
From: "Jason A. Donenfeld" <Jason@zx2c4.com>
To: Mathias Krause <minipli@grsecurity.net>
Cc: WireGuard mailing list <wireguard@lists.zx2c4.com>,
	Aymeric Fromherz <aymeric.fromherz@inria.fr>,
	 Karthik Bhargavan <karthikeyan.bhargavan@inria.fr>
Subject: Re: [PATCH 0/2] wireguard-linux-compat: grsecurity compat patches
Date: Mon, 13 Dec 2021 17:33:57 +0100	[thread overview]
Message-ID: <CAHmME9oh4Zx01E-+5S3Ds6mj6tVhJj81sTnSreDAujaFSX1u_Q@mail.gmail.com> (raw)
In-Reply-To: <ffb81284-53e4-dc94-75ec-d31b6a79f269@grsecurity.net>

Hi Mathias,

On Mon, Dec 13, 2021 at 5:32 PM Mathias Krause <minipli@grsecurity.net> wrote:
>
> Am 13.12.21 um 15:37 schrieb Jason A. Donenfeld:
> > On Mon, Dec 13, 2021 at 3:33 PM Mathias Krause <minipli@grsecurity.net> wrote:
> >> yeah, don't worry. We can keep this change downstream in grsec. Dunno if
> >> Jason wants to take it as well, his call. It was just a side observation
> >> which came out of our need to read and understand the code to provide a
> >> workaround for the gcc bug we were hitting.
> >
> > I suppose I can load it up in kbench9000 to see if it makes a
> > difference. If it doesn't matter much, I'd prefer sticking with the
> > formally verified stuff. But if there is a nice speedup, then I guess
> > we can revisit more handwavy "obviously this is the same thing"
> > arguments.
>
> Had to hack main.c and run.sh a little, but here are some numbers:
>
> root@box:~# ./run.sh
> [+] Setting no-turbo to status 1
> [+] Setting non-boot CPUs to status 0
> [+] Inserting module to run tests
> insmod: ERROR: could not insert module kbench9000.ko: Unknown symbol in
> module
> [+] Gathering results
>                  ever64: 115100 cycles per call
>            ever64_out_r: 115080 cycles per call
>           ever64_out_rm: 113957 cycles per call
> [+] Setting non-boot CPUs to status 1
> [+] Setting no-turbo to status 0
>
> Slightly faster.

Huh, that's actually a pretty nice speedup for just changing register
allocation... What CPU is this?

Jason

  reply	other threads:[~2021-12-13 16:34 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-06 13:27 Mathias Krause
2021-07-06 13:27 ` [PATCH 1/2] compat: better grsecurity compatibility Mathias Krause
2021-07-06 13:27 ` [PATCH 2/2] curve25519-x86_64: solve register constraints with reserved registers Mathias Krause
2021-08-08 20:53 ` [PATCH 0/2] wireguard-linux-compat: grsecurity compat patches Jason A. Donenfeld
2021-08-09 10:13   ` Mathias Krause
2021-12-03 22:20     ` Jason A. Donenfeld
2021-12-03 22:25       ` Jason A. Donenfeld
2021-12-06 14:04       ` Mathias Krause
2021-12-06 14:48         ` Jason A. Donenfeld
2021-12-06 16:24           ` Mathias Krause
2021-12-06 16:27             ` Jason A. Donenfeld
2021-12-06 18:18               ` Mathias Krause
2021-12-06 18:55                 ` Jason A. Donenfeld
2021-12-06 19:28                   ` Jason A. Donenfeld
2021-12-06 20:54                     ` Mathias Krause
2021-12-08 14:56                       ` Jason A. Donenfeld
2021-12-06 21:00                   ` Mathias Krause
2021-12-08 14:56                     ` Jason A. Donenfeld
2021-12-09  7:59                       ` Mathias Krause
2021-12-10 22:36                         ` Jason A. Donenfeld
2021-12-10 22:58                         ` Jason A. Donenfeld
2021-12-11 16:35                           ` Aymeric Fromherz
2021-12-12 21:43                             ` Jason A. Donenfeld
2021-12-13  7:54                               ` Mathias Krause
2021-12-13 11:36                                 ` Jason A. Donenfeld
2021-12-13 16:29                                   ` Jason A. Donenfeld
2021-12-13 16:46                                     ` Mathias Krause
2021-12-13  7:44                             ` Mathias Krause
2021-12-13 14:20                               ` Aymeric Fromherz
2021-12-13 14:33                                 ` Mathias Krause
2021-12-13 14:37                                   ` Jason A. Donenfeld
2021-12-13 16:32                                     ` Mathias Krause
2021-12-13 16:33                                       ` Jason A. Donenfeld [this message]
2021-12-13 16:39                                         ` Mathias Krause
2021-12-13 16:53                                           ` Jason A. Donenfeld

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAHmME9oh4Zx01E-+5S3Ds6mj6tVhJj81sTnSreDAujaFSX1u_Q@mail.gmail.com \
    --to=jason@zx2c4.com \
    --cc=aymeric.fromherz@inria.fr \
    --cc=karthikeyan.bhargavan@inria.fr \
    --cc=minipli@grsecurity.net \
    --cc=wireguard@lists.zx2c4.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).