Development discussion of WireGuard
 help / color / mirror / Atom feed
From: "Jason A. Donenfeld" <Jason@zx2c4.com>
To: Nikolay Aleksandrov <razor@blackwall.org>
Cc: Netdev <netdev@vger.kernel.org>,
	Daniel Borkmann <daniel@iogearbox.net>,
	 Martynas Pumputis <m@lambda.lt>,
	WireGuard mailing list <wireguard@lists.zx2c4.com>,
	 Jakub Kicinski <kuba@kernel.org>,
	David Miller <davem@davemloft.net>
Subject: Re: [PATCH net 2/2] wireguard: selftests: add metadata_dst xmit selftest
Date: Thu, 14 Apr 2022 14:06:04 +0200	[thread overview]
Message-ID: <CAHmME9ouN0O-mfi4d_xVon_SxzE4hbzdD0Zm8hRLS4k5C3dPFw@mail.gmail.com> (raw)
In-Reply-To: <20220414104458.3097244-3-razor@blackwall.org>

Hi Nikolay,

These tests need to run in the minimal fast-to-compile test harness
inside of tools/testing/selftests/wireguard/qemu, which you can try
out with:

$ make -C tools/testing/selftests/wireguard/qemu -j$(nproc)

Currently iproute2 is built, but only ip(8) is used in the image, so
you'll need to add tc(8) to there. Clang, however, seems a bit
heavyweight. I suspect it'd make more sense to just base64 up that
object file and include it as a string in the file? Or, alternatively,
we could just not move ahead with this rather niche test, and revisit
the issue if we wind up wanting to test for lots of bpf things.
Thoughts on that?

Jason

  reply	other threads:[~2022-04-14 12:08 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-14 10:44 [PATCH net 0/2] wireguard: device: fix metadata_dst xmit null pointer dereference Nikolay Aleksandrov
2022-04-14 10:44 ` [PATCH net 1/2] " Nikolay Aleksandrov
2022-04-14 11:28   ` Daniel Borkmann
2022-04-14 11:58   ` Jason A. Donenfeld
2022-04-14 10:44 ` [PATCH net 2/2] wireguard: selftests: add metadata_dst xmit selftest Nikolay Aleksandrov
2022-04-14 12:06   ` Jason A. Donenfeld [this message]
2022-04-14 12:12     ` Nikolay Aleksandrov
2022-04-14 12:24       ` Jason A. Donenfeld

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAHmME9ouN0O-mfi4d_xVon_SxzE4hbzdD0Zm8hRLS4k5C3dPFw@mail.gmail.com \
    --to=jason@zx2c4.com \
    --cc=daniel@iogearbox.net \
    --cc=davem@davemloft.net \
    --cc=kuba@kernel.org \
    --cc=m@lambda.lt \
    --cc=netdev@vger.kernel.org \
    --cc=razor@blackwall.org \
    --cc=wireguard@lists.zx2c4.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).