Re: [PATCH] systemd: add file wireguard.target

["Jason A. Donenfeld" <Jason@zx2c4.com>]

On Fri, May 1, 2020 at 3:29 PM Martin Hauke <mardnh@gmx.de> wrote:
>
> Am 01.05.20 um 01:21 schrieb Jason A. Donenfeld:
> > On Thu, Apr 30, 2020 at 7:56 AM Martin Hauke <mardnh@gmx.de> wrote:
> >> +PartOf=wireguard.target
> >
> > This won't reset wireguard interfaces configured by systemd-networkd,
> > nor interfaces configured manually, right? So maybe it's better to
> > call this wg-quick.target?
>
> Correct, then let's call this wg-quick.target .
>
> >> +Description=Target to restart all parts of WireGuard
> >
> > Is this verbage consistent with other systemd targets? Specifically,
> > is the "to restart" part apt? Or should this say something more
> > general?
>
> How about "Description=WireGuard target allowing to start/stop all
> wg-quick@.service instances at once" ?

Based on the language pattern established by below,
"Description=WireGuard Tunnels via wg-quick(8)" seems more fitting.

$ rg -g '*.target' ^Description= /lib/systemd
/lib/systemd/system/initrd-fs.target:Description=Initrd File Systems
/lib/systemd/system/printer.target:Description=Printer
/lib/systemd/system/kexec.target:Description=Reboot via kexec
/lib/systemd/system/emergency.target:Description=Emergency Mode
/lib/systemd/system/getty-pre.target:Description=Login Prompts (Pre)
/lib/systemd/system/local-fs.target:Description=Local File Systems
/lib/systemd/system/initrd-root-device.target:Description=Initrd Root Device
/lib/systemd/system/initrd-switch-root.target:Description=Switch Root
/lib/systemd/system/basic.target:Description=Basic System
/lib/systemd/system/umount.target:Description=Unmount All Filesystems
/lib/systemd/system/rescue.target:Description=Rescue Mode
/lib/systemd/system/reboot.target:Description=Reboot
/lib/systemd/system/poweroff.target:Description=Power-Off
/lib/systemd/system/remote-fs-pre.target:Description=Remote File Systems (Pre)
/lib/systemd/system/timers.target:Description=Timers
/lib/systemd/system/network-pre.target:Description=Network (Pre)
/lib/systemd/system/final.target:Description=Final Step
/lib/systemd/system/remote-cryptsetup.target:Description=Remote
Encrypted Volumes
/lib/systemd/system/hibernate.target:Description=Hibernate
/lib/systemd/system/getty.target:Description=Login Prompts
/lib/systemd/system/slices.target:Description=Slices
/lib/systemd/system/boot-complete.target:Description=Boot Completion Check
/lib/systemd/system/nss-user-lookup.target:Description=User and Group
Name Lookups
/lib/systemd/system/nss-lookup.target:Description=Host and Network Name Lookups
/lib/systemd/system/hybrid-sleep.target:Description=Hybrid Suspend+Hibernate
/lib/systemd/system/suspend-then-hibernate.target:Description=Suspend;
Hibernate if not used for a period of time
/lib/systemd/system/sockets.target:Description=Sockets
/lib/systemd/system/paths.target:Description=Paths
/lib/systemd/system/graphical.target:Description=Graphical Interface
/lib/systemd/system/cryptsetup.target:Description=Local Encrypted Volumes
/lib/systemd/system/local-fs-pre.target:Description=Local File Systems (Pre)
/lib/systemd/system/halt.target:Description=Halt
/lib/systemd/system/nfs-client.target:Description=NFS client services
/lib/systemd/system/rpcbind.target:Description=RPC Port Mapper
/lib/systemd/system/machines.target:Description=Containers
/lib/systemd/system/multi-user.target:Description=Multi-User System
/lib/systemd/system/network.target:Description=Network
/lib/systemd/system/swap.target:Description=Swap
/lib/systemd/system/network-online.target:Description=Network is Online
/lib/systemd/system/initrd.target:Description=Initrd Default Target
/lib/systemd/system/initrd-root-fs.target:Description=Initrd Root File System
/lib/systemd/system/smartcard.target:Description=Smart Card
/lib/systemd/system/shutdown.target:Description=Shutdown
/lib/systemd/system/bluetooth.target:Description=Bluetooth
/lib/systemd/system/system-update-pre.target:Description=Offline
System Update (Pre)
/lib/systemd/system/remote-fs.target:Description=Remote File Systems
/lib/systemd/system/time-sync.target:Description=System Time Synchronized
/lib/systemd/system/suspend.target:Description=Suspend
/lib/systemd/system/blockdev@.target:Description=Block Device Preparation for %f
/lib/systemd/system/sleep.target:Description=Sleep
/lib/systemd/system/system-update.target:Description=Offline System Update
/lib/systemd/system/nvmf-connect.target:Description=All instances of
nvmf-autoconnect daemon
/lib/systemd/system/sound.target:Description=Sound Card
/lib/systemd/system/exit.target:Description=Exit the container
/lib/systemd/system/time-set.target:Description=System Time Set
/lib/systemd/system/sysinit.target:Description=System Initialization
/lib/systemd/system/sigpwr.target:Description=Power Failure
/lib/systemd/system/cryptsetup-pre.target:Description=Local Encrypted
Volumes (Pre)