From: "Jason A. Donenfeld" <Jason@zx2c4.com>
To: Pablo Neira Ayuso <pablo@netfilter.org>
Cc: Netdev <netdev@vger.kernel.org>,
netfilter-devel@vger.kernel.org,
Jaap Buurman <jaapbuurman@gmail.com>,
openwrt-devel@lists.openwrt.org,
WireGuard mailing list <wireguard@lists.zx2c4.com>,
Felix Fietkau <nbd@nbd.name>
Subject: Re: Missing skb->dst with flow offloading
Date: Wed, 30 May 2018 20:14:42 +0200 [thread overview]
Message-ID: <CAHmME9p-Wdsd7=BaQJSnPKyPc+xyQkdMLGUz48O5b7yVwAmHzg@mail.gmail.com> (raw)
In-Reply-To: <20180530180547.kn4cikprj7drhlc3@salvia>
Hey Pablo,
On Wed, May 30, 2018 at 8:05 PM, Pablo Neira Ayuso <pablo@netfilter.org> wrote:
> If there a more drivers in-tree that need this, we may add
> skb_dst_set_noref() calls to _hook function in the flowtable codebase.
Can I, then, take that as an implicit acknowledgement that this
observed behavior on OpenWRT is to be expected with the current state
of events, and that I should patch my driver accordingly?
As one example of this in tree, take a look at vxlan -- it's using it
for the mtu/pmtu exactly as WireGuard does.
Regards,
Jason
next prev parent reply other threads:[~2018-05-30 18:12 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-30 0:01 Jason A. Donenfeld
2018-05-30 18:05 ` Pablo Neira Ayuso
2018-05-30 18:14 ` Jason A. Donenfeld [this message]
2018-05-30 18:24 ` Pablo Neira Ayuso
2018-05-30 18:30 ` Jason A. Donenfeld
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHmME9p-Wdsd7=BaQJSnPKyPc+xyQkdMLGUz48O5b7yVwAmHzg@mail.gmail.com' \
--to=jason@zx2c4.com \
--cc=jaapbuurman@gmail.com \
--cc=nbd@nbd.name \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=openwrt-devel@lists.openwrt.org \
--cc=pablo@netfilter.org \
--cc=wireguard@lists.zx2c4.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).