Development discussion of WireGuard
 help / color / mirror / Atom feed
From: "Jason A. Donenfeld" <Jason@zx2c4.com>
To: Martin Hauke <mardnh@gmx.de>
Cc: WireGuard mailing list <wireguard@lists.zx2c4.com>
Subject: Re: [PATCH] systemd: add file wireguard.target
Date: Thu, 30 Apr 2020 17:21:19 -0600	[thread overview]
Message-ID: <CAHmME9p0u2=i1+ApzsHicFy4VrGKOcE0sD_e5Yk5b-y9UrZBow@mail.gmail.com> (raw)
In-Reply-To: <20200430135551.9911-1-mardnh@gmx.de>

Hey Martin,

Thanks for the patch. Note that this needs to be submitted with your
`Signed-off-by: ` line, which `git commit -s --amend` will add for
you.

On Thu, Apr 30, 2020 at 7:56 AM Martin Hauke <mardnh@gmx.de> wrote:
> +PartOf=wireguard.target

This won't reset wireguard interfaces configured by systemd-networkd,
nor interfaces configured manually, right? So maybe it's better to
call this wg-quick.target?

> +Description=Target to restart all parts of WireGuard

Is this verbage consistent with other systemd targets? Specifically,
is the "to restart" part apt? Or should this say something more
general?

Jason

  parent reply	other threads:[~2020-04-30 23:22 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-30 13:55 Martin Hauke
2020-04-30 14:01 ` Riccardo Berto
2020-04-30 23:21 ` Jason A. Donenfeld [this message]
2020-05-01 21:29   ` Martin Hauke
2020-05-01 21:35     ` Jason A. Donenfeld

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAHmME9p0u2=i1+ApzsHicFy4VrGKOcE0sD_e5Yk5b-y9UrZBow@mail.gmail.com' \
    --to=jason@zx2c4.com \
    --cc=mardnh@gmx.de \
    --cc=wireguard@lists.zx2c4.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).