From: "Jason A. Donenfeld" <Jason@zx2c4.com>
To: Dave Taht <dave.taht@gmail.com>
Cc: WireGuard mailing list <wireguard@lists.zx2c4.com>
Subject: [WireGuard] WireGuard ECN Implementation
Date: Thu, 29 Sep 2016 19:50:19 +0200 [thread overview]
Message-ID: <CAHmME9p7LbqwSxSXgyjcam5f1cS0yM3E4WuLKnk8Ffm1QhQ4=A@mail.gmail.com> (raw)
Hey Dave,
I'm back! Catching up on the backlog now. You wrote in your blog post:
> In a day, the author (while on a plane!) tossed off an ecn encapsulation
> implementation (it worked! but it=E2=80=99s not currently as modern RFC c=
ompliant as it should be),
What part of it deviates from the RFC precisely? Here's a short
summary of the implementation:
- When a packet is transmitted:
outer_packet->ds =3D
ip_tunnel_ecn_encap(0, ip_hdr(inner_packet), inner_packet);
- When a packet is received:
var =3D ip_tunnel_get_dsfield(ip_hdr(outer_packet), outer_packet);
if (INET_ECN_is_ce(var))
IP_ECN_set_ce(ip_hdr(inner_packet));
What specifically is wrong with this? Where does it deviate from the
RFC? I'd like to be as "correct" as possible.
Talk soon,
Jason
next reply other threads:[~2016-09-29 17:39 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-29 17:50 Jason A. Donenfeld [this message]
2016-09-29 18:19 ` Dave Taht
2016-09-29 18:59 ` Jason A. Donenfeld
2016-09-29 19:03 ` Dave Taht
2016-09-29 19:05 ` Jason A. Donenfeld
2016-09-29 20:03 ` Dave Taht
2016-09-30 16:34 ` Jason A. Donenfeld
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHmME9p7LbqwSxSXgyjcam5f1cS0yM3E4WuLKnk8Ffm1QhQ4=A@mail.gmail.com' \
--to=jason@zx2c4.com \
--cc=dave.taht@gmail.com \
--cc=wireguard@lists.zx2c4.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).