From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Jason@zx2c4.com Received: from krantz.zx2c4.com (localhost [127.0.0.1]) by krantz.zx2c4.com (ZX2C4 Mail Server) with ESMTP id 6108bd1d for ; Tue, 20 Dec 2016 13:26:04 +0000 (UTC) Received: from frisell.zx2c4.com (frisell.zx2c4.com [192.95.5.64]) by krantz.zx2c4.com (ZX2C4 Mail Server) with ESMTP id d42ad777 for ; Tue, 20 Dec 2016 13:26:04 +0000 (UTC) Received: by frisell.zx2c4.com (ZX2C4 Mail Server) with ESMTP id 55eda180 for ; Tue, 20 Dec 2016 13:26:04 +0000 (UTC) Received: by frisell.zx2c4.com (ZX2C4 Mail Server) with ESMTPSA id eef2a709 (TLSv1.2:ECDHE-RSA-AES128-GCM-SHA256:128:NO) for ; Tue, 20 Dec 2016 13:26:04 +0000 (UTC) Received: by mail-oi0-f47.google.com with SMTP id w63so177750545oiw.0 for ; Tue, 20 Dec 2016 05:33:08 -0800 (PST) MIME-Version: 1.0 In-Reply-To: <59811706-CB39-4A8F-823B-9B270ABFD211@danrl.com> References: <20161220011334.GB16814@tuxmachine.polynome.dn42> <89D5D16F-84AF-4FC6-9AA1-55EFCB6A3B9E@danrl.com> <40FCA8CB-1FAA-42AF-B229-8692568F8226@danrl.com> <59811706-CB39-4A8F-823B-9B270ABFD211@danrl.com> From: "Jason A. Donenfeld" Date: Tue, 20 Dec 2016 14:33:06 +0100 Message-ID: Subject: Re: openwrt route_allowed_ips is inprecise To: =?UTF-8?Q?Dan_L=C3=BCdtke?= Content-Type: text/plain; charset=UTF-8 Cc: WireGuard mailing list List-Id: Development discussion of WireGuard List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Hi Dan, On Tue, Dec 20, 2016 at 11:15 AM, Dan L=C3=BCdtke wrote: > New environment, build from latest sources this morning. Can't reproduce.= I can't see duplicate routes. Static routes were added via LuCI to represe= nt a typical user's approach. > > Can we drop this discussion until we can reproduce the problem? That's a weird way of putting it, because you !=3D we. config wireguard_wg option public_key '0Nz4n2wdhDJtFbkdIFqlJ4vkKIGFgBVQPxyJ0XWE31o=3D' list allowed_ips '10.200.100.1/32' option route_allowed_ips '1' config interface 'wgnet' option proto 'static' option ifname 'wg' option ipaddr '10.200.100.4/24' --> root@mipsnet:~# ip r 10.200.100.0/24 dev wg src 10.200.100.4 10.200.100.1 dev wg We can drop the discussion, though, because Baptiste, the downstream package maintainer, doesn't want to maintain that kind of logic and evidently finds Linux's v4 LC-trie and v6 radix trie to be fast enough for his purposes. I don't find the duplicated entries very desirable, but I'm totally fine deferring to his judgement. >> I am on it. First version did add dependency for both protocols if the e= ndpoint name had A and AAAA records. However, I find it cleaner to check wh= ich endpoint wg chose to use and only add that IP address as an depedency. = Patch/PR comes when I am satisfied with stability. I think calling `wg show $if endpoints` like you do is the correct solution. Good thinking. I'll put some comments on the PR. Jason