Development discussion of WireGuard
 help / color / mirror / Atom feed
From: "Jason A. Donenfeld" <Jason@zx2c4.com>
To: kevans@freebsd.org
Cc: "WireGuard mailing list" <wireguard@lists.zx2c4.com>,
	"Bernhard Fröhlich" <decke@freebsd.org>,
	"Matt Dunwoodie" <ncon@noconroy.net>
Subject: Re: FreeBSD/wireguard-tools
Date: Tue, 9 Mar 2021 14:23:22 -0700	[thread overview]
Message-ID: <CAHmME9pQGWUo=Q0ohXUkXapS7rZ1qbP+GFHkDDOD2hp5VSD+Pw@mail.gmail.com> (raw)
In-Reply-To: <CACNAnaHUO_GvqQd3BJ2i4Wh45L=0g-LSxJg11G_dEa3UKK6GUw@mail.gmail.com>

Hi Kyle,

Thanks for getting in touch. So far as I can tell, Matt Macy never
finished either the port of wireguard-tools or the port of the actual
kernel module from OpenBSD. I'm CCng Matt Dunwoodie, who has started
working through the kernel module finding issues. There was that awful
error in 25519 (lack of scalar clamping) that somebody emailed me
about a while ago. I don't know if that was ever fixed but I was quite
surprised that got committed. I got the impression from trying to work
with Matt Macy that there wasn't too much interest in collaboration.
Your email is a very welcome change.

I see the path forward for FreeBSD having a functional WireGuard
implementation as something like this:

1. We work out kinks in the kernel module crypto and state machine. I
need to sync with Matt Dunwoodie on his findings there. Maybe we can
send patches ourselves, but maybe it'd be best to just have a
screensharing call where we walk through this together, and after the
call you can code/commit the problems that we identify from
discussion? A similar undertaking has been on my todo list for a
veryverylongtimenow for NetBSD, but that implementation is much, much
further behind, while in contrast I think with FreeBSD we're a lot
closer to things being where they should, and a lot of it will be a
simple matter of syncing the OpenBSD code. So if you're willing to
work with us, I think that's something we can get done together in a
week or faster.

2. We fix/simplify the kernel module's IPC interface to just be a
simple get/set, like every other implementation of WireGuard.

3. We write support for that IPC protocol as "ipc-freebsd.h" in
wireguard-tools. Maybe we'll start with Macy's code, but he never
incorporated the feedback I provided on that, so perhaps you'd like to
start over. Whatever you please there is fine with me.

4. I relicense the tools as MIT. I've previously started on getting
this done, and the only blocker was the embedded libmnl, which is LGPL
and out of my control. But I think there are two reasons why this is
not a real impediment: 1) I've been in touch with the author there,
and I think he'll MIT it if poke again, and 2) that's only for Linux
anyway, so you wouldn't need that file *at all* on FreeBSD.

Does that seem like a good plan? And if so, are you the right contact
with whom to work on it? And what's the FreeBSD release schedule like?
How long do we have to fix this?

Talk soon,
Jason

  reply	other threads:[~2021-03-09 21:25 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-09 21:04 FreeBSD/wireguard-tools Kyle Evans
2021-03-09 21:23 ` Jason A. Donenfeld [this message]
2021-03-10  3:14   ` FreeBSD/wireguard-tools Kyle Evans

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAHmME9pQGWUo=Q0ohXUkXapS7rZ1qbP+GFHkDDOD2hp5VSD+Pw@mail.gmail.com' \
    --to=jason@zx2c4.com \
    --cc=decke@freebsd.org \
    --cc=kevans@freebsd.org \
    --cc=ncon@noconroy.net \
    --cc=wireguard@lists.zx2c4.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).