Development discussion of WireGuard
 help / color / mirror / Atom feed
From: "Jason A. Donenfeld" <Jason@zx2c4.com>
To: Baptiste Jonglez <baptiste@bitsofnetworks.org>
Cc: WireGuard mailing list <wireguard@lists.zx2c4.com>
Subject: Re: Memleak with 0.0.20171221-5 on Debian stretch
Date: Mon, 12 Feb 2018 12:04:19 +0100	[thread overview]
Message-ID: <CAHmME9pvBg3OHLwun3uqdoCqmQBxxmwh1y2jxWUcdOKyZynNsA@mail.gmail.com> (raw)
In-Reply-To: <20180212074255.GB5305@tuxmachine.localdomain>

Hey Baptiste,

On Mon, Feb 12, 2018 at 8:42 AM, Baptiste Jonglez
<baptiste@bitsofnetworks.org> wrote:
> Actually, now that I talk about it, it's not 100% true: on this system,
> there is a second wireguard interface that is not currently used (it's
> provisionned to connect a future router that is not yet deployed).
>
> The interesting part: this interface has a single peer which has no
> endpoint but a persistent keepalive.

That's a super useful observation! I'm guessing this will fix it:
https://git.zx2c4.com/WireGuard/commit/?id=c5c22fb9bad1807a612b6055e0049d68f4600605

I'm still analyzing everything to find other places where I might have
missed something, but hopefully the above does it.

Jason

  reply	other threads:[~2018-02-12 10:57 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-11 13:48 Baptiste Jonglez
2018-02-11 18:20 ` Daniel Kahn Gillmor
2018-02-11 18:43   ` Baptiste Jonglez
2018-02-12  0:23     ` Jason A. Donenfeld
2018-02-12  7:35       ` Baptiste Jonglez
2018-02-12  7:42         ` Baptiste Jonglez
2018-02-12 11:04           ` Jason A. Donenfeld [this message]
2018-02-13 13:17             ` Baptiste Jonglez
2018-02-18 20:39               ` Jason A. Donenfeld
2018-02-22  7:45                 ` Baptiste Jonglez
2018-02-12  3:34     ` Daniel Kahn Gillmor

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAHmME9pvBg3OHLwun3uqdoCqmQBxxmwh1y2jxWUcdOKyZynNsA@mail.gmail.com \
    --to=jason@zx2c4.com \
    --cc=baptiste@bitsofnetworks.org \
    --cc=wireguard@lists.zx2c4.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).