* [PATCH] device: make locks more efficient
@ 2019-07-31 2:57 liuhaichao
2019-08-27 22:57 ` Jason A. Donenfeld
0 siblings, 1 reply; 3+ messages in thread
From: liuhaichao @ 2019-07-31 2:57 UTC (permalink / raw)
To: wireguard; +Cc: liuhaichao
From: liuhaichao <liuhaichao@bytedance.com>
Change-Id: I515c38e9911d4baeb4c2a45249c18a371864f8e1
---
device/uapi.go | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/device/uapi.go b/device/uapi.go
index 99cb421..c8499e2 100644
--- a/device/uapi.go
+++ b/device/uapi.go
@@ -283,12 +283,12 @@ func (device *Device) IpcSetOperation(socket *bufio.Reader) *IPCError {
logDebug.Println(peer, "- UAPI: Updating endpoint")
err := func() error {
- peer.Lock()
- defer peer.Unlock()
endpoint, err := CreateEndpoint(value)
if err != nil {
return err
}
+ peer.Lock()
+ defer peer.Unlock()
peer.endpoint = endpoint
return nil
}()
--
2.19.1
_______________________________________________
WireGuard mailing list
WireGuard@lists.zx2c4.com
https://lists.zx2c4.com/mailman/listinfo/wireguard
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] device: make locks more efficient
@ 2019-08-29 4:13 liuhaichao
0 siblings, 0 replies; 3+ messages in thread
From: liuhaichao @ 2019-08-29 4:13 UTC (permalink / raw)
To: wireguard; +Cc: Haichao Liu
From: Haichao Liu <liuhaichao@bytedance.com>
Change-Id: I515c38e9911d4baeb4c2a45249c18a371864f8e1
Signed-off-by: Haichao Liu <liuhaichao@bytedance.com>
---
device/uapi.go | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/device/uapi.go b/device/uapi.go
index 99cb421..c8499e2 100644
--- a/device/uapi.go
+++ b/device/uapi.go
@@ -283,12 +283,12 @@ func (device *Device) IpcSetOperation(socket *bufio.Reader) *IPCError {
logDebug.Println(peer, "- UAPI: Updating endpoint")
err := func() error {
- peer.Lock()
- defer peer.Unlock()
endpoint, err := CreateEndpoint(value)
if err != nil {
return err
}
+ peer.Lock()
+ defer peer.Unlock()
peer.endpoint = endpoint
return nil
}()
--
2.19.1
_______________________________________________
WireGuard mailing list
WireGuard@lists.zx2c4.com
https://lists.zx2c4.com/mailman/listinfo/wireguard
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-08-29 4:13 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-07-31 2:57 [PATCH] device: make locks more efficient liuhaichao
2019-08-27 22:57 ` Jason A. Donenfeld
2019-08-29 4:13 liuhaichao
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).