Development discussion of WireGuard
 help / color / mirror / Atom feed
From: "Jason A. Donenfeld" <Jason@zx2c4.com>
To: Patrick Havelange <patrick.havelange_ext@softathome.com>
Cc: wireguard@lists.zx2c4.com
Subject: Re: [PATCH] wg: syncconf: also handle psk changes
Date: Fri, 23 May 2025 20:28:33 +0200	[thread overview]
Message-ID: <CAHmME9q9t122WdD=kW6siHujMVjXOj-rehx-2wKFUuq15-dkQQ@mail.gmail.com> (raw)
In-Reply-To: <20250314093920.3448871-1-patrick.havelange_ext@softathome.com>

Your patch is wrong; did you test it? When it detects a mismatch in
PSK, it removes the peer, rather than removing the PSK.

I implemented a different fix:
https://git.zx2c4.com/wireguard-tools/commit/?id=780182e37d2b5981171766b8f31bcefd64da7a43
It seems to work for me, but please test this and let me know.

Either way, thanks for the bug report.

Thanks,
Jason

  reply	other threads:[~2025-05-23 18:28 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-14  9:39 Patrick Havelange
2025-05-23 18:28 ` Jason A. Donenfeld [this message]
2025-05-26  6:55   ` Patrick HAVELANGE (EXT)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAHmME9q9t122WdD=kW6siHujMVjXOj-rehx-2wKFUuq15-dkQQ@mail.gmail.com' \
    --to=jason@zx2c4.com \
    --cc=patrick.havelange_ext@softathome.com \
    --cc=wireguard@lists.zx2c4.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).