From: "Jason A. Donenfeld" <Jason@zx2c4.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: WireGuard mailing list <wireguard@lists.zx2c4.com>
Subject: Re: [PATCH 1/6] src/tools: add SPDX tags to all files
Date: Thu, 30 Nov 2017 18:57:20 +0100 [thread overview]
Message-ID: <CAHmME9q=z9eacusHGf2apYFCghYce5aEXFF7WXLqJ=nGMGD1hQ@mail.gmail.com> (raw)
In-Reply-To: <20171130152355.25387-2-gregkh@linuxfoundation.org>
On Thu, Nov 30, 2017 at 4:23 PM, Greg Kroah-Hartman
<gregkh@linuxfoundation.org> wrote:
> It's good to have SPDX identifiers in all files as the Linux kernel
> diff --git a/src/tools/config.c b/src/tools/config.c
> index 6ff03767f9e6..312cbcdd7a85 100644
> --- a/src/tools/config.c
> +++ b/src/tools/config.c
> @@ -1,3 +1,4 @@
> +// SPDX-License-Identifier: GPL-2.0
> /* Copyright (C) 2015-2017 Jason A. Donenfeld <Jason@zx2c4.com>. All Rights Reserved. */
>
> #include <arpa/inet.h>
> diff --git a/src/tools/config.h b/src/tools/config.h
> index 63a272cc1285..e3ad9f87404b 100644
> --- a/src/tools/config.h
> +++ b/src/tools/config.h
> @@ -1,3 +1,4 @@
> +/* SPDX-License-Identifier: GPL-2.0 */
> /* Copyright (C) 2015-2017 Jason A. Donenfeld <Jason@zx2c4.com>. All Rights Reserved. */
It looks like you're giving .h a /* style comment and .c a // style
comment. Is there a reason for this, or did you just have two
different sed commands by accident?
next prev parent reply other threads:[~2017-11-30 17:51 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-30 15:23 [PATCH 0/6] wireguard: add SPDX tags Greg Kroah-Hartman
2017-11-30 15:23 ` [PATCH 1/6] src/tools: add SPDX tags to all files Greg Kroah-Hartman
2017-11-30 17:57 ` Jason A. Donenfeld [this message]
2017-11-30 23:49 ` Jason A. Donenfeld
2017-12-01 9:41 ` Greg Kroah-Hartman
2017-11-30 15:23 ` [PATCH 2/6] src/selftest: " Greg Kroah-Hartman
2017-11-30 15:23 ` [PATCH 3/6] src/tests: " Greg Kroah-Hartman
2017-11-30 15:23 ` [PATCH 4/6] src/crypto: " Greg Kroah-Hartman
2017-11-30 15:23 ` [PATCH 5/6] src: " Greg Kroah-Hartman
2017-11-30 15:23 ` [PATCH 6/6] src/uapi/wireguard: add SPDX tag Greg Kroah-Hartman
2017-11-30 18:02 ` Jason A. Donenfeld
2017-12-01 9:43 ` Greg Kroah-Hartman
2017-11-30 17:54 ` [PATCH 0/6] wireguard: add SPDX tags Jason A. Donenfeld
2017-12-03 15:13 ` Jason A. Donenfeld
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHmME9q=z9eacusHGf2apYFCghYce5aEXFF7WXLqJ=nGMGD1hQ@mail.gmail.com' \
--to=jason@zx2c4.com \
--cc=gregkh@linuxfoundation.org \
--cc=wireguard@lists.zx2c4.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).