From: "Jason A. Donenfeld" <Jason@zx2c4.com>
To: Pablo Neira Ayuso <pablo@netfilter.org>
Cc: Netdev <netdev@vger.kernel.org>,
netfilter-devel@vger.kernel.org,
Jaap Buurman <jaapbuurman@gmail.com>,
openwrt-devel@lists.openwrt.org,
WireGuard mailing list <wireguard@lists.zx2c4.com>,
Felix Fietkau <nbd@nbd.name>
Subject: Re: Missing skb->dst with flow offloading
Date: Wed, 30 May 2018 20:30:03 +0200 [thread overview]
Message-ID: <CAHmME9qmurA1DJ=VaAnwu78OgHM5DQg7iZpoR+oh2s7pHs+inA@mail.gmail.com> (raw)
In-Reply-To: <20180530182442.wbgke26kaoau2du2@salvia>
On Wed, May 30, 2018 at 8:24 PM, Pablo Neira Ayuso <pablo@netfilter.org> wrote:
> May it crash the kernel because it's assuming is set? If so, then
> I'd appreciate if you send us a patch to
I suspect it won't crash, but the pmtu might wind up wrong / not calculated.
> Please, use the nf-next.git tree to patch nf_flow_offload_ip_hook()
> and nf_flow_offload_ip6_hook(), it's rather late, we'll request a
> -stable submission for this if needed.
Given the above, I'll submit a patch, though I don't suppose it will
be necessary for -stable.
prev parent reply other threads:[~2018-05-30 18:27 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-30 0:01 Jason A. Donenfeld
2018-05-30 18:05 ` Pablo Neira Ayuso
2018-05-30 18:14 ` Jason A. Donenfeld
2018-05-30 18:24 ` Pablo Neira Ayuso
2018-05-30 18:30 ` Jason A. Donenfeld [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHmME9qmurA1DJ=VaAnwu78OgHM5DQg7iZpoR+oh2s7pHs+inA@mail.gmail.com' \
--to=jason@zx2c4.com \
--cc=jaapbuurman@gmail.com \
--cc=nbd@nbd.name \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=openwrt-devel@lists.openwrt.org \
--cc=pablo@netfilter.org \
--cc=wireguard@lists.zx2c4.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).