Development discussion of WireGuard
 help / color / mirror / Atom feed
From: "Jason A. Donenfeld" <Jason@zx2c4.com>
To: Bruno Wolff III <bruno@wolff.to>
Cc: WireGuard mailing list <wireguard@lists.zx2c4.com>
Subject: Re: [PATCH] Merge two rcu types
Date: Thu, 14 Mar 2019 12:58:41 -0600	[thread overview]
Message-ID: <CAHmME9r-CrGs8JFPnWSkd8kKwgJqokOwFbi5g_DfVk+MKFXPzQ@mail.gmail.com> (raw)
In-Reply-To: <20190314171033.GB23073@wolff.to>

Ideally the way to fix this would be to replace our usages with the
proper non-_bh ones, and then in compat, based on a version
comparison, define the non-_bh to the _bh. The problem is that
ratelimiter.c uses non-_bh already, and it's unclear how bad it would
be if this suddenly became _bh on old kernels.

IIRC, the _bh variant of those functions has been aliased to non-_bh
since a few versions. Do you know the first time it was the same?
Perhaps if that's far enough back, then it'd be worth the effort to
try to qualify the breakage of improperly _bh-ing ratelimiter.c would
be on those kernels. On the other hand, if it's too recent or if the
breakage would actually be significant, we could always fallback to
the `#ifndef COMPAT_CANNOT_*` pattern used in a few other places
(which gets stripped out automatically for upstream submissions).
_______________________________________________
WireGuard mailing list
WireGuard@lists.zx2c4.com
https://lists.zx2c4.com/mailman/listinfo/wireguard

  reply	other threads:[~2019-03-14 18:58 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-14  5:16 Bruno Wolff III
2019-03-14 12:32 ` Bruno Wolff III
2019-03-14 17:10   ` Bruno Wolff III
2019-03-14 18:58     ` Jason A. Donenfeld [this message]
2019-03-14 20:05       ` Bruno Wolff III
2019-03-15  5:14         ` [PATCH] global: the _bh variety of rcu helpers have been unified Jason A. Donenfeld
2019-03-16 16:11           ` Bruno Wolff III

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAHmME9r-CrGs8JFPnWSkd8kKwgJqokOwFbi5g_DfVk+MKFXPzQ@mail.gmail.com \
    --to=jason@zx2c4.com \
    --cc=bruno@wolff.to \
    --cc=wireguard@lists.zx2c4.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).