Development discussion of WireGuard
 help / color / mirror / Atom feed
From: "Jason A. Donenfeld" <Jason@zx2c4.com>
To: Maxim Cournoyer <maxim.cournoyer@gmail.com>
Cc: WireGuard mailing list <wireguard@lists.zx2c4.com>
Subject: Re: [bug] No keep-alives sent when private is set via PostUp
Date: Thu, 18 May 2023 03:17:42 +0200	[thread overview]
Message-ID: <CAHmME9rEKX_8s=WxoeBg5xf-5FLVxTm6q8Wo=-FrwRCuT7FX6Q@mail.gmail.com> (raw)
In-Reply-To: <87fs7xtqrv.fsf@gmail.com>

Hi Maxim,

Thanks for the bug report! I think indeed you're right about this. Can
you test if this commit fixes the issue for you?

https://git.zx2c4.com/wireguard-linux/commit/?id=3ac1bf099766f1e9735883d5127148054cd5b30a

It at least satisfies the test case I added.

Until this patch hits stable kernels, you can probably work around
this by changing your PostUp into a PreUp. I adjusted the man page
here:

https://git.zx2c4.com/wireguard-tools/commit/?id=9d42bd1ab9d707f7a72162d36c9b37cc9bdf480e

Jason

  reply	other threads:[~2023-05-18  1:18 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-15 18:04 Maxim Cournoyer
2023-05-18  1:17 ` Jason A. Donenfeld [this message]
2023-05-18  1:22   ` Jason A. Donenfeld
2023-05-18  2:04     ` Maxim Cournoyer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAHmME9rEKX_8s=WxoeBg5xf-5FLVxTm6q8Wo=-FrwRCuT7FX6Q@mail.gmail.com' \
    --to=jason@zx2c4.com \
    --cc=maxim.cournoyer@gmail.com \
    --cc=wireguard@lists.zx2c4.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).