From: "Jason A. Donenfeld" <Jason@zx2c4.com>
To: Simon Rozman <simon@rozman.si>
Cc: Shawn Hoffman <godisgovernment@gmail.com>,
"wireguard@lists.zx2c4.com" <wireguard@lists.zx2c4.com>
Subject: Re: [PATCH 0/1] wintun: use standard volatile semantics
Date: Sat, 25 Apr 2020 02:51:43 -0600 [thread overview]
Message-ID: <CAHmME9rSMmdCgLdO1ST2ECWFbFvmUxmWWO+QXe+7+pitAhe8uw@mail.gmail.com> (raw)
In-Reply-To: <B6B013EB-18CF-4017-A096-3512B19C9963@rozman.si>
On Sat, Apr 25, 2020 at 12:23 AM Simon Rozman <simon@rozman.si> wrote:
>
> Hi Shawn!
>
> Thank you. This generally looks good. I can't find any official documentation on the set of functions and macros from wdm.h, but that's nothing new with Microsoft.
>
> I have some nitpicks thou.
>
> 1. As the atomic.h is no longer used; it could be deleted from the repo.
> 2. By removing #include "atomic.h", you should add #include <wdm.h>. wintun.c is now directly using functions and macros declared in wdm.h.
> 3. Please add "Signed-of-by: Shawn Hoffman <godisgovernment@gmail.com>" line to your commit message.
He resubmitted with his S-o-b line. See that patch series for the latest.
prev parent reply other threads:[~2020-04-25 8:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-24 19:40 Shawn Hoffman
2020-04-24 19:40 ` [PATCH 1/1] replace atomic.h with provided APIs switch to /volatile:iso Shawn Hoffman
2020-04-25 6:23 ` [PATCH 0/1] wintun: use standard volatile semantics Simon Rozman
2020-04-25 8:51 ` Jason A. Donenfeld [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHmME9rSMmdCgLdO1ST2ECWFbFvmUxmWWO+QXe+7+pitAhe8uw@mail.gmail.com \
--to=jason@zx2c4.com \
--cc=godisgovernment@gmail.com \
--cc=simon@rozman.si \
--cc=wireguard@lists.zx2c4.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).