DKMS build failure on kernel 3.13 (Ubuntu 14.04)

DKMS build failure on kernel 3.13 (Ubuntu 14.04)

[Jonathon Fernyhough]

[-- Attachment #1.1: Type: text/plain, Size: 971 bytes --]

Hi!

In testing out the new kernel<4.1 support I've hit a build failure:

> In file included from include/net/ip_tunnels.h:5:0,
>                  from /var/lib/dkms/wireguard/0.0.20170409-1~14.04.york0.1/build/compat/compat.h:62,
>                  from <command-line>:0:
> include/linux/netdevice.h:1890:43: error: macro "dev_recursion_level" passed 1 arguments, but takes just 0
>  static inline int dev_recursion_level(void)
>                                            ^
> include/linux/netdevice.h:1891:1: error: expected ‘=’, ‘,’, ‘;’, ‘asm’ or ‘__attribute__’ before ‘{’ token
>  {
>  ^

This looks to be related to lines 43-48 of src/compat/compat.h where
there's `#define dev_recursion_level() 0`. I'm not yet sure whether
Ubuntu have tweaked or backported something, or whether the 1-arity
function exists in mainline kernel 3.13.

(If there's an issue/bug tracker I've missed let me know)

Regards,

Jonathon


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

Re: DKMS build failure on kernel 3.13 (Ubuntu 14.04)

[Jason A. Donenfeld]

Hey Jonathon,

3.13, as released from kernel.org, does not have this function, which
is why it's "defined" in the compat.h. It appears you're using
somebody's insane backport. It wouldn't surprise me if Canonical
decided to try and maintain 3.13 past kernel.org's maintenance. Is
this the latest kernel in 14.04?

Regards,
Jason

Re: DKMS build failure on kernel 3.13 (Ubuntu 14.04)

[Jonathon Fernyhough]

[-- Attachment #1.1: Type: text/plain, Size: 884 bytes --]

On 11/04/17 12:26, Jason A. Donenfeld wrote:
> Hey Jonathon,
> 
> 3.13, as released from kernel.org, does not have this function, which
> is why it's "defined" in the compat.h. It appears you're using
> somebody's insane backport. It wouldn't surprise me if Canonical
> decided to try and maintain 3.13 past kernel.org's maintenance. Is
> this the latest kernel in 14.04?
> 
> Regards,
> Jason
> 

3.13 is 14.04's 'official' kernel. They do have the 16.04 kernel
available (4.4) for 14.04 which I've been using successfully with wireguard.

They do indeed maintain these kernels beyond mainline's EOL (instead of
sticking with one of the LTS versions for their... LTS release).
Thankfully 4.4 is an LTS version so 16.04 is in a better default position.

It's easy enough to work around if this is out-of-scope for wireguard,
which it sounds like it is.


J


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]