From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Jason@zx2c4.com Received: from krantz.zx2c4.com (localhost [127.0.0.1]) by krantz.zx2c4.com (ZX2C4 Mail Server) with ESMTP id 862d789b for ; Mon, 26 Jun 2017 11:38:37 +0000 (UTC) Received: from frisell.zx2c4.com (frisell.zx2c4.com [192.95.5.64]) by krantz.zx2c4.com (ZX2C4 Mail Server) with ESMTP id 15975818 for ; Mon, 26 Jun 2017 11:38:37 +0000 (UTC) Received: by frisell.zx2c4.com (ZX2C4 Mail Server) with ESMTP id 56f4f7a7 for ; Mon, 26 Jun 2017 11:52:11 +0000 (UTC) Received: by frisell.zx2c4.com (ZX2C4 Mail Server) with ESMTPSA id 3166b396 (TLSv1.2:ECDHE-RSA-AES128-GCM-SHA256:128:NO) for ; Mon, 26 Jun 2017 11:52:10 +0000 (UTC) Received: by mail-ot0-f169.google.com with SMTP id y47so65725159oty.0 for ; Mon, 26 Jun 2017 04:54:59 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <20170626113011.Horde.LnrakzTxipAs-PhMdgApTF3@www.vdorst.com> References: <20170626113011.Horde.LnrakzTxipAs-PhMdgApTF3@www.vdorst.com> From: "Jason A. Donenfeld" Date: Mon, 26 Jun 2017 13:54:56 +0200 Message-ID: Subject: Re: Hash fix commit by Sultan Alsawaf. To: =?UTF-8?Q?Ren=C3=A9_van_Dorst?= Content-Type: multipart/alternative; boundary="001a113d0a24c11a370552db9e0e" Cc: Sultan XDA , WireGuard mailing list List-Id: Development discussion of WireGuard List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , --001a113d0a24c11a370552db9e0e Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Yes. It's totally bogus since the struct initializer already zeros these bytes. On Jun 26, 2017 13:36, "Ren=C3=A9 van Dorst" wrote: > Jason, > > Did you notice this commit [1] from Sultan Alsawaf? > > [1] ratelimiter: fix hashing and hashmap searching for ipv4 addresses; > https://git.zx2c4.com/WireGuard/commit/?h=3Dsa/20170623&id=3D8da > 15aa96cdf918d8a98cf2caaefb475cadee355 > > Greats, > > Ren=C3=A9 van Dorst. > > _______________________________________________ > WireGuard mailing list > WireGuard@lists.zx2c4.com > https://lists.zx2c4.com/mailman/listinfo/wireguard > --001a113d0a24c11a370552db9e0e Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Yes. It's tot= ally bogus since the struct initializer already zeros these bytes.

On Jun 26, 201= 7 13:36, "Ren=C3=A9 van Dorst" <opensource@vdorst.com> wrote:
Jason,

Did you notice this commit [1] from Sultan Alsawaf?

[1] ratelimiter: fix hashing and hashmap searching for ipv4 addresses; https://git.zx2c4.com/WireGuard/commit/?h=3Dsa/20170623&id=3D8da<= wbr>15aa96cdf918d8a98cf2caaefb475cadee355

Greats,

Ren=C3=A9 van Dorst.

_______________________________________________
WireGuard mailing list
WireGuard@li= sts.zx2c4.com
https://lists.zx2c4.com/mailman/listinfo/wire= guard
--001a113d0a24c11a370552db9e0e--