Development discussion of WireGuard
 help / color / mirror / Atom feed
From: "Jason A. Donenfeld" <Jason@zx2c4.com>
To: Laura Zelenku <laura.zelenku@wandera.com>
Cc: Aaron Jones <me@aaronmdjones.net>,
	WireGuard mailing list <wireguard@lists.zx2c4.com>
Subject: Re: [PATCH] Respect WG protocol reserved bytes
Date: Wed, 17 Mar 2021 07:10:50 -0600	[thread overview]
Message-ID: <CAHmME9rkLGQb9nGpoLwDt4V-D+rv43JU_mmT96ww1wQfTnSpmw@mail.gmail.com> (raw)
In-Reply-To: <2240E688-898B-4F74-B954-0754464F6352@wandera.com>

On 3/17/21, Laura Zelenku <laura.zelenku@wandera.com> wrote:
> If the client send some data in reserved bytes you will have logs full of
> errors because the message gets type from 4 bytes instead of 1 byte (like it
> is in protocol description).
> I would like implementation respects protocol -
> https://www.wireguard.com/papers/wireguard.pdf . Yes, in our project we use
> reserved bytes.
>
> I know that when there are zeros in reserved bytes, everything is correct.
> But if you receive some non-zero value in reserved bytes?
>

Aaron is right.

Those bytes MUST be set to zero. Otherwise you're now implementing a
different protocol. Do not use reserved bytes. They are not reserved
for you.

      reply	other threads:[~2021-03-17 13:11 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-17  7:55 Laura Zelenku
2021-03-17 12:35 ` Aaron Jones
2021-03-17 12:53   ` Laura Zelenku
2021-03-17 13:10     ` Jason A. Donenfeld [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAHmME9rkLGQb9nGpoLwDt4V-D+rv43JU_mmT96ww1wQfTnSpmw@mail.gmail.com \
    --to=jason@zx2c4.com \
    --cc=laura.zelenku@wandera.com \
    --cc=me@aaronmdjones.net \
    --cc=wireguard@lists.zx2c4.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).