Development discussion of WireGuard
 help / color / mirror / Atom feed
* [PATCH] Use localtime in inf2cat
@ 2020-11-30  9:32 Stefan Rinkes
  2020-12-02 13:45 ` Jason A. Donenfeld
  0 siblings, 1 reply; 3+ messages in thread
From: Stefan Rinkes @ 2020-11-30  9:32 UTC (permalink / raw)
  To: wireguard

[-- Attachment #1: Type: text/plain, Size: 54 bytes --]

Else build fails in other timezones at certain times.

[-- Attachment #2: 0001-Use-localtime-in-inf2cat.patch --]
[-- Type: application/octet-stream, Size: 834 bytes --]

From 04ab8baaacc0f41eee2b56642da1fb104edac5ed Mon Sep 17 00:00:00 2001
From: Stefan Rinkes <stefan.rinkes@gmail.com>
Date: Mon, 30 Nov 2020 10:10:00 +0100
Subject: [PATCH] Use localtime in inf2cat

Else build fails in other timezones at certain times.
---
 driver/driver.vcxproj | 1 +
 1 file changed, 1 insertion(+)

diff --git a/driver/driver.vcxproj b/driver/driver.vcxproj
index cbfed3e..dac2c98 100644
--- a/driver/driver.vcxproj
+++ b/driver/driver.vcxproj
@@ -46,6 +46,7 @@
     <ConfigurationType>Driver</ConfigurationType>
     <DriverType>WDM</DriverType>
     <SpectreMitigation>false</SpectreMitigation>
+    <Inf2CatUseLocalTime>true</Inf2CatUseLocalTime>
   </PropertyGroup>
   <PropertyGroup Condition="'$(Configuration)'=='Release'" Label="Configuration">
     <UseDebugLibraries>false</UseDebugLibraries>
-- 
2.25.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] Use localtime in inf2cat
  2020-11-30  9:32 [PATCH] Use localtime in inf2cat Stefan Rinkes
@ 2020-12-02 13:45 ` Jason A. Donenfeld
       [not found]   ` <CAMy1ncJtqYE6GQY4pQfq7=hw05SMRceC=unAQgGXcnLX=SAcQQ@mail.gmail.com>
  0 siblings, 1 reply; 3+ messages in thread
From: Jason A. Donenfeld @ 2020-12-02 13:45 UTC (permalink / raw)
  To: Stefan Rinkes; +Cc: WireGuard mailing list

Hi Stefan,

Thanks for the patch. So this is why I couldn't build the driver
between midnight and 2am here in France. :) Actually, I'd seen
something about this on an old Microsoft blog, and had just forgotten
whether there was a good solution. I'm glad you found it and sent this
patch.

I can't apply this patch as-is because it's missing your Signed-off-by
line. So you'll need to resubmit if you'd like it to be committed with
your authorship. Otherwise I'll fall back to a Reported-by: line.

Jason

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] Use localtime in inf2cat
       [not found]   ` <CAMy1ncJtqYE6GQY4pQfq7=hw05SMRceC=unAQgGXcnLX=SAcQQ@mail.gmail.com>
@ 2020-12-02 14:05     ` Jason A. Donenfeld
  0 siblings, 0 replies; 3+ messages in thread
From: Jason A. Donenfeld @ 2020-12-02 14:05 UTC (permalink / raw)
  To: Stefan Rinkes, WireGuard mailing list

On Wed, Dec 2, 2020 at 3:02 PM Stefan Rinkes <stefan.rinkes@gmail.com> wrote:
>
> Hey,
>
> Sure! Attached the patch including the signed-off line.
>
> Greetz
> Stefan

Thanks! Applied:

https://git.zx2c4.com/wintun/commit/?id=dd337577185f2d5cf76df2e14b833acf52923817

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2020-12-02 14:06 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-30  9:32 [PATCH] Use localtime in inf2cat Stefan Rinkes
2020-12-02 13:45 ` Jason A. Donenfeld
     [not found]   ` <CAMy1ncJtqYE6GQY4pQfq7=hw05SMRceC=unAQgGXcnLX=SAcQQ@mail.gmail.com>
2020-12-02 14:05     ` Jason A. Donenfeld

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).