From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.zx2c4.com (lists.zx2c4.com [165.227.139.114]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 57708C433EF for ; Wed, 12 Jan 2022 13:22:29 +0000 (UTC) Received: by lists.zx2c4.com (OpenSMTPD) with ESMTP id 7a8db901; Wed, 12 Jan 2022 13:18:51 +0000 (UTC) Received: from ams.source.kernel.org (ams.source.kernel.org [2604:1380:4601:e00::1]) by lists.zx2c4.com (OpenSMTPD) with ESMTPS id 8dbf9927 (TLSv1.2:ECDHE-ECDSA-AES256-GCM-SHA384:256:NO) for ; Wed, 12 Jan 2022 13:18:49 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 84FFFB81DFF for ; Wed, 12 Jan 2022 13:18:49 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 44ACAC36AF7 for ; Wed, 12 Jan 2022 13:18:48 +0000 (UTC) Authentication-Results: smtp.kernel.org; dkim=pass (1024-bit key) header.d=zx2c4.com header.i=@zx2c4.com header.b="d40SY2Xa" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=zx2c4.com; s=20210105; t=1641993526; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=rRXjtbrE2Eve7J58Q9IJgxX8+W28gZ0ioA+AryafyRo=; b=d40SY2XaCIk0dSlLUT5yjkzn3M731524Y1ppya4erUzgWWKIfM4qfTNSnK+z4My2VtBHXW kY3JoOps/+i3GCja/QwYYVHvShcqblBHaBFJwykbJvD7elDljSpfkdiDVO5apndncszVww r9uzpV3ySCfDaeWWK9lpAKJ0ZFgh8i4= Received: by mail.zx2c4.com (ZX2C4 Mail Server) with ESMTPSA id 3c15f7e7 (TLSv1.3:AEAD-AES256-GCM-SHA384:256:NO) for ; Wed, 12 Jan 2022 13:18:46 +0000 (UTC) Received: by mail-yb1-f170.google.com with SMTP id n68so6277811ybg.6 for ; Wed, 12 Jan 2022 05:18:46 -0800 (PST) X-Gm-Message-State: AOAM531WW3OaSpSoL9v8KLKJjvQTcMwM2hsvOJxHxeGz47zVeitcCcYV tQtIgkb6A0EGZViy7f4y2VgYzCKpHut4s3m6edI= X-Google-Smtp-Source: ABdhPJyQQ3vU6dkRjERWgWVka3PYGzTNU58ke8Z1uEGxTGLJbZG9wlOxUKuZ4qw6Bp1eNeWmkh3Xxr5iM9ffSIBlHoE= X-Received: by 2002:a5b:10:: with SMTP id a16mr12918334ybp.115.1641993525094; Wed, 12 Jan 2022 05:18:45 -0800 (PST) MIME-Version: 1.0 References: <20220111181037.632969-1-Jason@zx2c4.com> <20220111220506.742067-1-Jason@zx2c4.com> In-Reply-To: From: "Jason A. Donenfeld" Date: Wed, 12 Jan 2022 14:18:34 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH crypto v3 0/2] reduce code size from blake2s on m68k and other small platforms To: Geert Uytterhoeven Cc: Linux Crypto Mailing List , netdev , WireGuard mailing list , Linux Kernel Mailing List , bpf , Theodore Tso , Greg KH , Jean-Philippe Aumasson , Ard Biesheuvel , Herbert Xu Content-Type: text/plain; charset="UTF-8" X-BeenThere: wireguard@lists.zx2c4.com X-Mailman-Version: 2.1.30rc1 Precedence: list List-Id: Development discussion of WireGuard List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: wireguard-bounces@lists.zx2c4.com Sender: "WireGuard" Hi Geert, On Wed, Jan 12, 2022 at 12:00 PM Geert Uytterhoeven wrote: > Thanks for the series! > > On m68k: > add/remove: 1/4 grow/shrink: 0/1 up/down: 4/-4232 (-4228) > Function old new delta > __ksymtab_blake2s256_hmac 12 - -12 > blake2s_init.constprop 94 - -94 > blake2s256_hmac 302 - -302 > sha1_transform 4402 582 -3820 > Total: Before=4230537, After=4226309, chg -0.10% > > Tested-by: Geert Uytterhoeven Excellent, thanks for the breakdown. So this shaves off ~4k, which was about what we were shooting for here, so I think indeed this series accomplishes its goal of counteracting the addition of BLAKE2s. Hopefully Herbert will apply this series for 5.17. Jason